From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Richard Stallman <rms@gnu.org>
Cc: acm@muc.de, emacs-devel@gnu.org
Subject: Re: A proposal for the future of open-paren-in-column-0-is-defun-start.
Date: Mon, 06 Apr 2020 11:40:05 -0400 [thread overview]
Message-ID: <jwv1rp0fx66.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1jLHdh-0005Ld-Hk@fencepost.gnu.org> (Richard Stallman's message of "Sun, 05 Apr 2020 22:37:29 -0400")
> In that case, we could arrange for open-paren-in-column-0-is-defun-start
> to be heeded _along with_ comment-use-syntax-ppss.
Be my guest. But before accepting such code, I'll want to see some
concrete evidence that it has a real benefit.
So far, all concrete evidence we have has no direct connection to
open-parens-in-column-0 (other than some people's gut feelings).
We should treat this performance problem the same as any other: do the
profiling, look into the code that takes the major part of the time,
look into why it takes so much time, ...
So far we have: scrolling is too slow in some C buffer and the profile
indicates it happens "somewhere in jit-lock". There's a lot that might
be going on "in jit-lock", so we've barely scratched the surface of
the problem.
My gut feeling is that we're going to find that we're not spending much
of that time in `back_comment` (the C function which used this
open-paren-in-column-0 heuristic). This seems to be confirmed by the
fact that setting comment-use-syntax-ppss to nil made no difference: the
problem is elsewhere and we're just wasting time discussing this old
heuristic whose time has passed.
Stefan
next prev parent reply other threads:[~2020-04-06 15:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 13:47 A proposal for the future of open-paren-in-column-0-is-defun-start Alan Mackenzie
2020-04-05 14:33 ` Stefan Monnier
2020-04-05 15:23 ` Alan Mackenzie
2020-04-05 18:39 ` Stefan Monnier
2020-04-06 2:37 ` Richard Stallman
2020-04-06 15:40 ` Stefan Monnier [this message]
2020-04-06 16:04 ` Eli Zaretskii
2020-04-06 16:25 ` Stefan Monnier
2020-04-06 16:36 ` Eli Zaretskii
2020-04-06 17:49 ` Stefan Monnier
2020-04-06 18:16 ` Eli Zaretskii
2020-04-06 18:32 ` andres.ramirez
2020-04-07 8:33 ` martin rudalics
2020-04-07 13:47 ` Stefan Monnier
2020-04-07 14:06 ` Eli Zaretskii
2020-04-06 19:08 ` Dmitry Gutov
2020-04-06 21:42 ` Stefan Monnier
2020-04-06 21:58 ` Dmitry Gutov
2020-04-06 23:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1rp0fx66.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.