From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-27 36873ef: Fix error message for =?utf-8?Q?=E2=80=98cl-struct-unknown-slot=E2=80=99?= (bug#39995) Date: Sun, 12 Apr 2020 19:10:23 -0400 Message-ID: References: <20200412131247.9567.83889@vcs0.savannah.gnu.org> <20200412131248.5125520D0C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="51218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 13 01:11:07 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNlko-000DG3-Ix for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Apr 2020 01:11:06 +0200 Original-Received: from localhost ([::1]:38636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNlkn-0002g8-Ln for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Apr 2020 19:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54136) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNlkD-0002A4-Oq for emacs-devel@gnu.org; Sun, 12 Apr 2020 19:10:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNlkC-0001Xm-5t for emacs-devel@gnu.org; Sun, 12 Apr 2020 19:10:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15099) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNlkC-0001XS-02 for emacs-devel@gnu.org; Sun, 12 Apr 2020 19:10:28 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 451BA10033A; Sun, 12 Apr 2020 19:10:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 682B5100311; Sun, 12 Apr 2020 19:10:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1586733025; bh=mlIw4RNl9xnOZt6/WkNKlJtTSQcxlSde1FpC3zNNyv0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dTKhhpIiePemg8plgvges05wKdB2QYvpbHDO7+hoSairmS1RDzZe9G4JATmHgVXwE KeftnNWCgDeMorh5rtoK2sh5o1A2VDZ/0iaBE7QE10HU41a417ygtf2lHCQDg7H50W a1T6gBa1gEpKDm/I+LH847WgX/TWYCs1qfrsE+rp4iSxSAk9eTX4qaPqERaPotuTnN 22hjvxhplNe+2IU627MALH4ps0a2VeJuAH3wR+xeCOSiAMADxTuOwTpjwJw8ayxLnE H97Yo4pp5Eh/ItGw1GVWhVuGu3RFMUtnJWpG/0a4m/6i0NWLd5TH36osTMOypBnqdc AiQ9PzLfsN5CQ== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D764B120795; Sun, 12 Apr 2020 19:10:24 -0400 (EDT) In-Reply-To: <20200412131248.5125520D0C@vcs0.savannah.gnu.org> (Philipp Stephani's message of "Sun, 12 Apr 2020 09:12:47 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246875 Archived-At: > -(define-error 'cl-struct-unknown-slot "struct %S has no slot %S") > +(define-error 'cl-struct-unknown-slot "struct has no slot") Thanks Philipp, This reminds me that we really should provide better control over `error-message-string` so we can give better error messages (e.g. via `format` or something else). Stefan