From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#41810: 28.0.50; [ELPA] adaptive-wrap: Fontify wrap-prefix Date: Thu, 11 Jun 2020 18:42:26 -0400 Message-ID: References: <87k10d7f2v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="54596"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41810@debbugs.gnu.org, Stephen Berman To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 12 00:43:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjVuf-000E5t-NO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jun 2020 00:43:09 +0200 Original-Received: from localhost ([::1]:33766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjVue-0004je-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jun 2020 18:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjVuY-0004jJ-2c for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 18:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjVuX-0006Km-Q6 for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 18:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jjVuX-0004NX-Nz for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 18:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jun 2020 22:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41810 X-GNU-PR-Package: emacs Original-Received: via spool by 41810-submit@debbugs.gnu.org id=B41810.159191535616795 (code B ref 41810); Thu, 11 Jun 2020 22:43:01 +0000 Original-Received: (at 41810) by debbugs.gnu.org; 11 Jun 2020 22:42:36 +0000 Original-Received: from localhost ([127.0.0.1]:38332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjVu8-0004Mp-BO for submit@debbugs.gnu.org; Thu, 11 Jun 2020 18:42:36 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjVu7-0004Ma-9O for 41810@debbugs.gnu.org; Thu, 11 Jun 2020 18:42:35 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 974A080292; Thu, 11 Jun 2020 18:42:29 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C1B52809C8; Thu, 11 Jun 2020 18:42:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1591915347; bh=/Ufy2YbCyDAf8sJIoxkf0W/G430D2hqJk/oWoWzr9JI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YNhP3GG1eQjG0gZF2t1eLDdZ86T4tysLzXvKZBAuualIaAjQyawGdeQKC8gGpx/p1 X9AYOW95Zfv2m9CdJhMw6I5phNkPeV4Y/zLhH9l89UzufX/+lrfbs+387xKYOu9bwv eZjAHwY2GV29ZHELHzugAo8HdJcZGTDFiJcF58X9I0UabfRoECtujKJGgS3+6qRutd yk1my7illG9B5Ti7G4D6ZkJ4efW8QdZfkJJ/dDC33nzDWR/vQYZDfpcCM44nFNZod5 VxmTTBZy6LV4xGWbGl8d3JV2MNKw3TPZ4QaS8BE2tdKnH0G3rMfBziYV9GrmSUzuVW rrswmH4ISRz9g== Original-Received: from alfajor (unknown [216.154.55.41]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 865C51203E4; Thu, 11 Jun 2020 18:42:27 -0400 (EDT) In-Reply-To: <87k10d7f2v.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Thu, 11 Jun 2020 18:16:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181874 Archived-At: > The comment's continuation line starts with ";;;;". I see two problems > with this: > > 1. The padding characters are not propertized, so we get two fontified > semicolons, then two unfontified semicolons. That looks ugly, indeed. IIRC the reason is that when we extract the prefix from the buffer, font-lock hasn't applied its `face` text property yet. > 2. Visually, this looks sort of cluttered. I have searched Debbugs and > emacs-devel for a rationale for using (substring fcp -1) instead of > unconditionally using spaces, but I could not find any. I think it just seemed like a good idea. I suspect it's a matter of taste. Not sure if it's important enough to justify offering both behaviors. > See second screenshot, taken from emacs -Q -rv, with: That's ugly, indeed. Not sure whether the problem really comes from nor where it should be fixed, but it's clearly a bug. Stefan