From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: Nonax <nonax@posteo.net>, emacs-devel@gnu.org
Subject: Re: Recursive Fload and eval-after-load forms. (See bug #43116.)
Date: Tue, 01 Sep 2020 19:42:33 -0400 [thread overview]
Message-ID: <jwv1rjlqluc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200901194255.GB12507@ACM> (Alan Mackenzie's message of "Tue, 1 Sep 2020 19:42:55 +0000")
> - (cond ((symbolp load) (ignore-errors (require load)))
> + (cond ((being-loaded-p load)) ; For bug #43116
> + ((symbolp load) (ignore-errors (require load)))
Maybe a simpler test that doesn't require a new ad-hoc primitive is to
test whether that group has already been defined?
Stefan
diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 466727630f..8f1e5968b5 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -4844,7 +4844,8 @@ custom-menu-create
(if (and (or (not (boundp 'custom-menu-nesting))
(>= custom-menu-nesting 0))
(progn
- (custom-load-symbol symbol)
+ (unless (get symbol 'group-documentation)
+ (custom-load-symbol symbol))
(< (length (get symbol 'custom-group)) widget-menu-max-size)))
(let ((custom-prefix-list (custom-prefix-add symbol
custom-prefix-list))
next prev parent reply other threads:[~2020-09-01 23:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 18:45 Recursive Fload and eval-after-load forms. (See bug #43116.) Alan Mackenzie
2020-08-31 18:54 ` Stefan Monnier
2020-08-31 19:42 ` Alan Mackenzie
2020-09-01 3:18 ` Stefan Monnier
2020-09-01 19:42 ` Alan Mackenzie
2020-09-01 23:42 ` Stefan Monnier [this message]
2020-08-31 20:27 ` Nonax
2020-08-31 20:27 ` bug#43116: " Nonax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1rjlqluc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=nonax@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.