From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 0d7d09b: Test for error with multibyte strings in bindat.el Date: Thu, 22 Oct 2020 11:32:45 -0400 Message-ID: References: <20201022132026.11259.71984@vcs0.savannah.gnu.org> <20201022132028.35E5C209D4@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26565"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 22 17:37:15 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVceQ-0006pl-PN for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Oct 2020 17:37:14 +0200 Original-Received: from localhost ([::1]:44342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVceP-000797-Qr for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Oct 2020 11:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVcaA-0002t7-QF for emacs-devel@gnu.org; Thu, 22 Oct 2020 11:32:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVca9-0005On-AQ for emacs-devel@gnu.org; Thu, 22 Oct 2020 11:32:50 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 53AEC80C56; Thu, 22 Oct 2020 11:32:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CF35A80917; Thu, 22 Oct 2020 11:32:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1603380766; bh=qGqJNO1wL2q0wCHUcmO+wuuzxbu4GDIe70FAZHZ/FDM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AXDmXtCg4yz/auUGgicDzURPV0jRVqgB+q00WxG0DdO75TwxEPFjQWtZMLHfKGULA m2GOLqRI2kfiAatcODaW9HnVS1ENtGXJZ8N97N48xHaS0NnQ54T/fFGIp2iKE2D0np 2DODqNP47bti85p2RPBa6/50JP4vW7zzE1WTkrGDKHHWwvna+/5snHKuut0opmFLzC 8BCzRw1IeTNFEdz9ToIwOmS3zlTP925engGEOGp9LzsTpLJj+Lf07Tr4ZO/K5qxNrq pPaG6AK5fRvsQSImwVKCFvlCsvKmznaZU1xK8yuPEuSoP30J3RLx/ZJSIM59Qryo0x p5o3NZ0NpmdYg== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9D2B2120328; Thu, 22 Oct 2020 11:32:46 -0400 (EDT) In-Reply-To: <20201022132028.35E5C209D4@vcs0.savannah.gnu.org> (Stefan Kangas's message of "Thu, 22 Oct 2020 09:20:27 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/22 11:17:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258299 Archived-At: > + (should-error (bindat-pack nil nil (decode-coding-string "=F6" 'utf-8)= ))) I don't understand this code: "=F6" is a multibyte string, i.e. a sequence of chars (and not a sequence of bytes), so you can "encode" it to a sequence of bytes but "decoding" it makes no sense (and should ideally signal an error, tho I think we currently refrain from doing so). Stefan