all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master 0d7d09b: Test for error with multibyte strings in bindat.el
Date: Thu, 22 Oct 2020 11:32:45 -0400	[thread overview]
Message-ID: <jwv1rhq46rh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20201022132028.35E5C209D4@vcs0.savannah.gnu.org> (Stefan Kangas's message of "Thu, 22 Oct 2020 09:20:27 -0400 (EDT)")

> +  (should-error (bindat-pack nil nil (decode-coding-string "ö" 'utf-8))))

I don't understand this code: "ö" is a multibyte string,
i.e. a sequence of chars (and not a sequence of bytes), so you can
"encode" it to a sequence of bytes but "decoding" it makes no sense
(and should ideally signal an error, tho I think we currently refrain
from doing so).


        Stefan




       reply	other threads:[~2020-10-22 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201022132026.11259.71984@vcs0.savannah.gnu.org>
     [not found] ` <20201022132028.35E5C209D4@vcs0.savannah.gnu.org>
2020-10-22 15:32   ` Stefan Monnier [this message]
2020-10-22 16:10     ` master 0d7d09b: Test for error with multibyte strings in bindat.el Stefan Kangas
2020-10-22 16:44       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1rhq46rh.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.