From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025). Date: Thu, 11 Mar 2021 15:36:26 -0500 Message-ID: References: <20210310151754.12884.67231@vcs0.savannah.gnu.org> <20210310151755.C7D8D211CF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 11 21:38:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKS4H-0002yJ-SB for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 21:38:01 +0100 Original-Received: from localhost ([::1]:38736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKS4G-0007bK-U8 for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 15:38:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKS34-0006oI-5E for emacs-devel@gnu.org; Thu, 11 Mar 2021 15:36:48 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKS2x-0005kl-G3 for emacs-devel@gnu.org; Thu, 11 Mar 2021 15:36:43 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9C0AA10023D; Thu, 11 Mar 2021 15:36:37 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 43D2B1001D2; Thu, 11 Mar 2021 15:36:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615494988; bh=qpa+smeL7aqyqL3VaaTy0Xb7+waVmvr1HGugLQ+lMpc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h7xIiV6XM47Msnmc57N8voYpEaFtVoPBiLRQvogiyIBi//osPW/7k8a1sQUURUgmK pa59l8bAQ+xhmlJXPJU51u7CycDzJnAYAjk9VRLI7LvBtKpsm4AIRV1bWdbNoPvYjU j6wmMz4wf8gxsyhsd++5ZBIISKlJ95QDqBGW5fMCyAiNCJANWOM/FEWQd1OtKF8+7c bxSQk777Kk7250bEXR5Ng5nTP34Gcu7HTqzfY8KIke92O+AiFl70t8ieI39WVrl/s3 M1O3/jajXaoft/0hUNKhHVX2XeDpzB3DWj5y4jTSEctjSNa25hNyg0jTgiZSltZpOR qqjsTMW/IpsCg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9D75D120310; Thu, 11 Mar 2021 15:36:27 -0500 (EST) In-Reply-To: (Andrea Corallo's message of "Thu, 11 Mar 2021 19:29:02 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266361 Archived-At: >>> -(if (byte-code-function-p (symbol-function 'macroexpand-all)) >>> +(if (or (byte-code-function-p (symbol-function 'macroexpand-all)) >>> + (subr-native-elisp-p (symbol-function 'macroexpand-all))) >> BTW, I find this rather ugly. > I thought this is very similar to one of the two suggested :) It was much more elegant when I wrote it ;-) Stefan