From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completion-all-sorted-completions`: Sort alphabetically Date: Mon, 19 Apr 2021 18:09:03 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6417"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "emacs-devel@gnu.org" To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 20 00:10:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYc5f-0001Xf-Iw for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Apr 2021 00:09:59 +0200 Original-Received: from localhost ([::1]:49522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYc5e-00044l-Mb for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Apr 2021 18:09:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYc4r-0003eN-5I for emacs-devel@gnu.org; Mon, 19 Apr 2021 18:09:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYc4p-0007J5-6G for emacs-devel@gnu.org; Mon, 19 Apr 2021 18:09:08 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DDDD210021B; Mon, 19 Apr 2021 18:09:05 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 83B411000C4; Mon, 19 Apr 2021 18:09:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1618870144; bh=D3w2XvtP1WT7K1oKoVZQqOr3qCwRweQv/+ER+LVbWxU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DUgYRjhLoiUHa++yDudbetMxLUDtuMKdzgpIWqegFiGojytgLmxvxtHVxJHlgx0oY JMR0dliQfGbBVkY/BXixQsORpsqAUt1P3nQ3vI0vsWk67rs5axEcGoVEPn/QYEnKAe PcJdukBORtsNdVtjWe9hc6y33kyDY11GcgLYHpl8Hy5WN0zqaTtWYSExrZYQAH2Gcw W5EgE4yveyXTTLG4gfe+VtRDbeaR5jypsgqqlnzLwTqskezXffTES7hcdMRLBioM5p iFFrfB6+Ek2Ey2k99b4P40a1KbRvKCTLOFDNYVHdn4irQZuslN+z7aT4+FslJPrEs1 E0jVa7dhvC9fQ== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5BAAB120296; Mon, 19 Apr 2021 18:09:04 -0400 (EDT) In-Reply-To: (Daniel Mendler's message of "Mon, 19 Apr 2021 23:02:21 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268195 Archived-At: > Patch attached which adds the alphabetical sorting to > `completion-all-sorted-completions`. I extracted the sorting functions > for readability. Thanks. Pushed after tweaking the commit message to better follow our conventions. Stefan