From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Understanding end-of-defun Date: Thu, 27 Oct 2022 11:25:59 -0400 Message-ID: References: <46FF2036-9AB4-4C57-82B5-51260D287FC5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23865"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 27 17:29:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo4op-0005wp-A4 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Oct 2022 17:29:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo4lq-00087Y-8i; Thu, 27 Oct 2022 11:26:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo4ln-0007iA-Ox for emacs-devel@gnu.org; Thu, 27 Oct 2022 11:26:12 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo4li-00063a-FY for emacs-devel@gnu.org; Thu, 27 Oct 2022 11:26:10 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1CD9780796; Thu, 27 Oct 2022 11:26:02 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6A1FE80355; Thu, 27 Oct 2022 11:26:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666884360; bh=zdgS3gIWgsTELol9mF/oHyQbXLsTa3N18PKcek7j02I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lnxrbXibsrW99n13Onbp7REzumPF4Xpm/5T3jCqg/fWl2XxzyzJdX/FMU0q7f223T +DIfRDE9OO5QVt9QuIhgpXcuO8aVfF20BHj+uQrUr5m9QoJmLWKkFeIl2RFfeDAYIU VIG1yeCEFtHLAagctkrJah334tXTSca37DjPYIpbnad45u0Fu/U2R2nh2PovmwZkwx LDL/XLz83pornqPJkrIz18WpkkBl0CwCXpgPnRcmwl26XbljarUpsQcAor+fVD9ijO vz05IHQf80qzmc6E3ccSCuW6uY6vg2FuYeGD5UkoH1riIw/T+D9Vq/xjPtbJx0mZdB rZYHyE+TIbGwQ== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3ED511203D7; Thu, 27 Oct 2022 11:26:00 -0400 (EDT) In-Reply-To: (Yuan Fu's message of "Wed, 26 Oct 2022 21:44:50 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298626 Archived-At: >> No, you're quite right. We should double check that >> `beginning-of-defun-raw` was successful (and do something else if not). > How about: I haven't had a chance to try it out, but it looks good to me, tho `beginning-of-defun-raw` doesn't mention anything about its return value in the its docstring, so we may want to tweak that docstring (and review its code to make sure that it indeed returns the value we need in all cases, tho I suspect you've done so already). Stefan