From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/greader 9118905f71: greader.el: make hook variables local. Date: Fri, 21 Jul 2023 10:43:40 -0400 Message-ID: References: <168992628144.9486.12496062148767287614@vcs2.savannah.gnu.org> <20230721075801.AEC9BC138F3@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38980"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michelangelo Rodriguez To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 21 16:45:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMrNM-0009v7-VA for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jul 2023 16:45:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMrML-0007yz-5n; Fri, 21 Jul 2023 10:43:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMrMF-0007yN-4Z for emacs-devel@gnu.org; Fri, 21 Jul 2023 10:43:51 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMrM8-0002qi-U1 for emacs-devel@gnu.org; Fri, 21 Jul 2023 10:43:50 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 846A28060E; Fri, 21 Jul 2023 10:43:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 435EF80508; Fri, 21 Jul 2023 10:43:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689950621; bh=JgTPx3yzkLmp4j/v4hX0azFGH0KxaObA9pW4k5lIUR4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X4St+SqUsotq3e1z9AhNI5csV2D4lEUcbLZW6GfZ4k6SJQqHTTwqq7BLyjK61BAwR XTE2FZcmGoxxHq+R6FxFPJQaxUYWY5z6Jo2qQEDzUoUKe3fTqkz7Y2qhJqqHz3FhLs VE7JfrWWxYgd00fbXqCV9oO5IZu0pQMvJRXW2NbCkkQ2lIovhDE0M93n0NaTUjprq7 UvzPQDfSL6brUVONX7FczUgJUjPWfroZhYiTAfY9fhh9kL6QqPqSLlaMiQD0dIbJbQ kBA0WDhiSarnDN1I8Gtt/Lf4q70xgceHakmUFBRygoX/GDEXJT77+bdkgWt3oYm5nm KRpccyZe3uLkQ== Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1DFBD120346; Fri, 21 Jul 2023 10:43:41 -0400 (EDT) In-Reply-To: <20230721075801.AEC9BC138F3@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Fri, 21 Jul 2023 03:58:01 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308000 Archived-At: > -(defvar greader-before-get-sentence-functions nil > +(defvar-local greader-before-get-sentence-functions nil > -(defvar greader-after-get-sentence-functions nil > +(defvar-local greader-after-get-sentence-functions nil > -(defvar greader-before-read-hook nil > +(defvar-local greader-before-read-hook nil > -(defvar greader-after-read-hook nil > +(defvar-local greader-after-read-hook nil > -(defvar greader-before-finish-hook nil > +(defvar-local greader-before-finish-hook nil Please don't. Hooks already have their own mechanism for that: the `local` arg of `add-hook`. Stefan