all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/greader 9118905f71: greader.el: make hook variables local.
       [not found] ` <20230721075801.AEC9BC138F3@vcs2.savannah.gnu.org>
@ 2023-07-21 14:43   ` Stefan Monnier
  0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2023-07-21 14:43 UTC (permalink / raw)
  To: emacs-devel; +Cc: Michelangelo Rodriguez

> -(defvar greader-before-get-sentence-functions nil
> +(defvar-local greader-before-get-sentence-functions nil
> -(defvar greader-after-get-sentence-functions nil
> +(defvar-local greader-after-get-sentence-functions nil
> -(defvar greader-before-read-hook nil
> +(defvar-local greader-before-read-hook nil
> -(defvar greader-after-read-hook nil
> +(defvar-local greader-after-read-hook nil
> -(defvar greader-before-finish-hook nil
> +(defvar-local greader-before-finish-hook nil

Please don't.  Hooks already have their own mechanism for that: the
`local` arg of `add-hook`.


        Stefan




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-07-21 14:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <168992628144.9486.12496062148767287614@vcs2.savannah.gnu.org>
     [not found] ` <20230721075801.AEC9BC138F3@vcs2.savannah.gnu.org>
2023-07-21 14:43   ` [elpa] externals/greader 9118905f71: greader.el: make hook variables local Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.