all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Michelangelo Rodriguez <michelangelo.rodriguez@gmail.com>
Subject: Re: [elpa] externals/greader 9118905f71: greader.el: make hook variables local.
Date: Fri, 21 Jul 2023 10:43:40 -0400	[thread overview]
Message-ID: <jwv1qh1pbqk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20230721075801.AEC9BC138F3@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Fri, 21 Jul 2023 03:58:01 -0400 (EDT)")

> -(defvar greader-before-get-sentence-functions nil
> +(defvar-local greader-before-get-sentence-functions nil
> -(defvar greader-after-get-sentence-functions nil
> +(defvar-local greader-after-get-sentence-functions nil
> -(defvar greader-before-read-hook nil
> +(defvar-local greader-before-read-hook nil
> -(defvar greader-after-read-hook nil
> +(defvar-local greader-after-read-hook nil
> -(defvar greader-before-finish-hook nil
> +(defvar-local greader-before-finish-hook nil

Please don't.  Hooks already have their own mechanism for that: the
`local` arg of `add-hook`.


        Stefan




           reply	other threads:[~2023-07-21 14:43 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20230721075801.AEC9BC138F3@vcs2.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1qh1pbqk.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=michelangelo.rodriguez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.