From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/android a496509ced 1/2: Update Android port Date: Wed, 16 Aug 2023 11:03:34 -0400 Message-ID: References: <167413804086.19235.17391196197706660128@vcs2.savannah.gnu.org> <20230119142043.05B19C00613@vcs2.savannah.gnu.org> <87il9fjhyq.fsf@yahoo.com> <87y1ibi2gm.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29818"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 16 17:06:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWI6s-0007WP-Nc for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Aug 2023 17:06:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWI4T-0004M3-7d; Wed, 16 Aug 2023 11:04:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWI3j-0003mN-EH for emacs-devel@gnu.org; Wed, 16 Aug 2023 11:03:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWI3f-0004Fw-FC for emacs-devel@gnu.org; Wed, 16 Aug 2023 11:03:41 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8D8D844287E; Wed, 16 Aug 2023 11:03:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1692198215; bh=uspSb4BlYsxlmQ3eobA89HZTB83TAVbOGnUQSTn08Uc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dlnbtKSnX0swHvXOkUAg6D7ZtxD2G/V4EIW+FFrJsBrd8+y4fXZgq3FLoJbm+aJdg WQZIUCSp1c0tpQ2+RWrpqe4NV95V5Rk39IlHp0GwtJUNJD1yHk4mo4MC305x2T5wAu fPPGNnQZ2maKxXPxNDNgLEMeet2KJYCYBm47ieC4TyzQOXSA/rANRmti9DzdhVZOL9 otGbgn6gbp2+pDkXYnbDIOr5yan+QfPeN4p+TTqxf/4wgGNrSKA003UI1CamtW5T/W 1+u0t1TZtME4QhjxmI515MS2GeVAOymc7KJvObq/vy2PJKuwl1k4dR74ANquNwlNc6 W3445oX90Lu5Q== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 35F83442851; Wed, 16 Aug 2023 11:03:35 -0400 (EDT) Original-Received: from pastel (unknown [45.72.228.154]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E5BDE12020D; Wed, 16 Aug 2023 11:03:34 -0400 (EDT) In-Reply-To: (Po Lu's message of "Wed, 16 Aug 2023 22:15:53 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308826 Archived-At: >> I don't really understand how this answers my question. >> Is "the mouse position list" an "posn"? > Yes. We refer to "posns" as mouse position lists. Ah, great, thanks. >> If yes, then why doesn't `event-start/end` return it? > It does, so I've removed the redundant code from widget.el. Where? The code I see on `master` is: (defun event-end (event) "Return the ending position of EVENT. EVENT should be a click, drag, or key press event. See `event-start' for a description of the value returned." (declare (side-effect-free t)) (or (and (consp event) (not (memq (car event) '(touchscreen-begin touchscreen-update touchscreen-end))) (nth (if (consp (nth 2 event)) 2 1) event)) (event--posn-at-point))) so for `touchscreen-begin` we return (event--posn-at-point). What am I missing? Stefan