From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work Date: Tue, 24 Oct 2023 10:50:03 -0400 Message-ID: References: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> <8334y4s0oe.fsf@gnu.org> <83v8axmbsh.fsf@gnu.org> <83y1fskyjj.fsf@gnu.org> <83il6wktxt.fsf@gnu.org> <83h6mgkst3.fsf@gnu.org> <83edhkkrzd.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7688"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 24 16:51:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvIkQ-0001mw-1n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Oct 2023 16:51:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvIk1-0000KM-OM; Tue, 24 Oct 2023 10:50:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvIjt-0000Fz-OL for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 10:50:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvIjp-0005LL-4p for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 10:50:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvIkI-0008Pz-OD for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2023 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66655 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 66655-submit@debbugs.gnu.org id=B66655.169815904932323 (code B ref 66655); Tue, 24 Oct 2023 14:51:02 +0000 Original-Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 14:50:49 +0000 Original-Received: from localhost ([127.0.0.1]:56156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvIk4-0008PG-Hf for submit@debbugs.gnu.org; Tue, 24 Oct 2023 10:50:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvIjw-0008Ou-6N for 66655@debbugs.gnu.org; Tue, 24 Oct 2023 10:50:47 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3C99D10013E; Tue, 24 Oct 2023 10:50:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1698159004; bh=dyHlfO/ieYUIf9QHaInNAtYmnsROhAcvnYoh0Mg9Xmo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FWzpowhWPM1dY0REoKfZ0CtXUEPJ/2lCWsbUryEtuzqwznqfS7UQJTMbPSILgIeBr AIQ8lMDqn7tNhvagkeAeJiehjnMetOf4aAS0Pqnd2ZmFBKVAIayTvY889J1w1OHaNE 3ldZiIVFYUpaDKt7vutUtXL2IjvNg44K2yqM4luMROhqxe+gtWMlBK6Ui24ljKNRZg nYNc+8lQN715oyWF8qoUV4L7rbJDohMKL5rjUrefsSSrJagP3eAVcor/jHKrrr6Wyf 60OLcFfyaFM5gNCQM9WDaYdWA1cCCdVIahBvsRec4QuxOm26eDiMMbEbZkBL8SpJGR wuqjok3kwWtdQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EF703100061; Tue, 24 Oct 2023 10:50:03 -0400 (EDT) Original-Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C6C851201BB; Tue, 24 Oct 2023 10:50:03 -0400 (EDT) In-Reply-To: <83edhkkrzd.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Oct 2023 17:36:06 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273112 Archived-At: > change if the change is small enough. So I'm not sure I understand > what is new in your idea, if you want to keep the double-click-fuzz > test. What's new is the `mouse_has_moved` boolean which remembers if the mouse has been moved some time between the down and the up, contrary to the current code which only looks at the relative position of the down and the up. The patch looks big mostly because it reverts your patch. Setfan