From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ola x Nilsson Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Mon, 21 Aug 2023 14:04:46 +0200 Message-ID: References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19293"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mauro Aranda , 64046@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 21 14:06:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qY3gC-0004lk-VW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Aug 2023 14:06:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY3fz-0000sp-7p; Mon, 21 Aug 2023 08:06:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY3fp-0000oc-07 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 08:06:22 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY3fU-0005yK-Cn for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 08:06:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qY3fW-0008Ku-Gq for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 08:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ola x Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169261951731991 (code B ref 64046); Mon, 21 Aug 2023 12:06:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 21 Aug 2023 12:05:17 +0000 Original-Received: from localhost ([127.0.0.1]:55745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3em-0008Jv-JE for submit@debbugs.gnu.org; Mon, 21 Aug 2023 08:05:16 -0400 Original-Received: from smtp2.axis.com ([195.60.68.18]:32815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3el-0008Jc-2c for 64046@debbugs.gnu.org; Mon, 21 Aug 2023 08:05:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1692619513; x=1724155513; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=gqRZXge0t5FzBPEUW/Llw33dwa31MjGrfCEakoSdmRo=; b=Zt2MQ64klZqfDi+ZBYY//9bC1FwtO/IOId4tU4rsZwjOa6aQmP98bBuB 5PpXvuNhtve8XmNSiY+RxzNjeyldrJ896BsnXOAiPCB8q1u3Q3XWpBKe6 PNhrVuAu0J3Pgo0Y2l0vJvPuMFr7ITRl2TMpHP62hSiWWx7DLcquUtENH JBEZsoN0Nzjtvoye/xfycKF6N7G6K+n2PEKHhJgCtd3IseivZDMw8D/UU AfXG5WNx6ci18CZJUT0Rcsbz29GaJ/zUycnG/P2i63hBqfBN8swPKcr1y yZ1PUtpcLBvA/p/2cdrjBU1Au1ES5PmyItGKvhgazxT/wVfVsn7YSbZWi w==; In-Reply-To: <87r0p2l5pp.fsf@gmx.net> (Stephen Berman's message of "Thu, 20 Jul 2023 21:53:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268084 Archived-At: On Thu, Jul 20 2023, Stephen Berman wrote: > On Thu, 20 Jul 2023 16:11:33 -0300 Mauro Aranda = wrote: > >> Stephen Berman writes: >> >>> On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda >> wrote: >>> >>>> Turns out this code introduces regressions when customizing faces. >>>> >>>> With emacs -Q: >>>> M-x customize-face RET default >>>> Action the State button and choose: "For All Kinds of Displays" >>>> Action the Display menu and select "specific display" >>>> Wrong type argument: number-or-marker-p, "=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 " >>>> >>>> The substitute-command-keys operation is too destructive, and messes >>>> with things it shouldn't be modifying, like the :offset property of >>>> widgets in this case. >> >>> Sorry for not responding sooner; I was travelling and only now had time >>> to look into this.=C2=A0 If I debugged it correctly, the problem is tha= t the >>> value of :extra-offset, 9, satisfies char-or-string-p, so then due to my >>> patch substitute-command-keys turns it into a string containing a TAB. >> >> No trouble at all.=C2=A0 And yes, that sounds correct to me. >> >>> The cases intended to be fixed by my patch are where strings with grave >>> quoting occur, which should be turned into strings with curve quoting. >>> If so, then testing for stringp suffices, and the attached patch avoids >>> the regression you found and gives the desired results for the other >>> cases discussed in this bug.=C2=A0 I don't know why I used char-or-stri= ng-p >>> instead of stringp in my original patch, and don't see a reason for it >>> now.=C2=A0 Or do you know of cases where testing for stringp is insuffi= cient? >> >> I don't know, but I feel like stringp should suffice.=C2=A0 So please in= stall >> your fix, and I will be alert if something else breaks. > > Thanks, pushed to master as commit c55e67081e9. > > Steve Berman [Resending as the bug was archived]=20 I think I ran into another problem with the change. Using the simple item definitions (described in the docstring), this call=20 (widget-choose "Title" '(("Option1" . "Foo") ("Option 2" . "Bar"))) will fail with (wrong-type-argument (listp "Foo")) Or did I misunderstand how that mode works? /Ola