From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#11485: In configure.in, gl_EARLY is too early? Date: Tue, 15 May 2012 22:34:34 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1337135706 11892 80.91.229.3 (16 May 2012 02:35:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 16 May 2012 02:35:06 +0000 (UTC) To: 11485@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 16 04:35:04 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SUU4r-00015z-LF for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 May 2012 04:35:01 +0200 Original-Received: from localhost ([::1]:36324 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUU4r-0004ze-0m for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 May 2012 22:35:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUU4n-0004zL-HX for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 22:34:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUU4l-0006Lx-I9 for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 22:34:57 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUU4l-0006Lr-EN for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 22:34:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SUU4r-0006co-Ls for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 22:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 May 2012 02:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11485 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: submit@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.133713568625444 (code B ref -1); Wed, 16 May 2012 02:35:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 May 2012 02:34:46 +0000 Original-Received: from localhost ([127.0.0.1]:56846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUU4b-0006cJ-GC for submit@debbugs.gnu.org; Tue, 15 May 2012 22:34:46 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:41582 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUU4Y-0006cB-MR for submit@debbugs.gnu.org; Tue, 15 May 2012 22:34:43 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SUU4Q-00085k-QT; Tue, 15 May 2012 22:34:34 -0400 X-Spook: Putin embassy government CDMA satellite imagery X-Ran: +$+0iQZ5}q?h~[&erv!!UtT$>%PM);b?iR=U&%T,}Q|~(5;@joFzp%):AUhEnZ00l#E^|\ X-Hue: white X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60055 Archived-At: Package: emacs Version: 24.0.96 Severity: important configure.in contains the equivalent of this (abridged): ## On several platforms: NON_GNU_CPP= # Initialize gnulib right after verifying that the C compiler works. gl_EARLY [...] ## If no CPP was specified, do something for Sun compilers. if [...] && test x"$CPP" = x; then [do stuff] [...] ## If NON_GNU_CPP was set and CPP was not, set CPP to NON_GNU_CPP. if test "x$NON_GNU_CPP" != x && test x$GCC != xyes && test "x$CPP" = x then CPP="$NON_GNU_CPP" fi [...] AC_PROG_CPP The CPP tests all predate the use of Gnulib. What gl_EARLY does is opaque, but by inspection of configure one thing it ends up doing is calling AC_PROG_CPP and so setting $CPP much earlier than the rest of configure.in expects. IIUC, this will prevent all the pre-existing code related to changing CPP from having any effect; because it all tests if CPP was already set, and if so does nothing. It was expecting that CPP could only have been set by the user at this stage; however now gnulib is going to make it always be set. Moving gl_EARLY later in configure.in (to just before the check for -Wdeclaration-after-statement) would presumably restore the behaviour of Emacs 23 and earlier. However, all previous pretesting for Emacs 24 has used the other behaviour, so I do not know if it is too late to change this. It affects the less common platforms, which might not have seen much testing. One example is using a Sun compiler on Solaris. The intent of configure was to add -Xs to the CPP options.