From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Date: Thu, 18 Jan 2018 17:55:22 -0500 Message-ID: References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> <83efmnuhgo.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516316072 13482 195.159.176.226 (18 Jan 2018 22:54:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Jan 2018 22:54:32 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: phst@google.com, p.stephani2@gmail.com, 30106@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 18 23:54:27 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJ4P-00024Z-Nz for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 23:54:05 +0100 Original-Received: from localhost ([::1]:33164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecJ6P-0001Vf-SW for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 17:56:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecJ6J-0001UZ-My for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 17:56:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecJ6I-0006AT-Ro for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 17:56:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54162) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecJ6I-0006AM-O9 for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 17:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ecJ6I-00074e-Er for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 17:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jan 2018 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30106 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30106-submit@debbugs.gnu.org id=B30106.151631614227165 (code B ref 30106); Thu, 18 Jan 2018 22:56:02 +0000 Original-Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 22:55:42 +0000 Original-Received: from localhost ([127.0.0.1]:33826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJ5x-000744-TB for submit@debbugs.gnu.org; Thu, 18 Jan 2018 17:55:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJ5u-00073q-EK for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 17:55:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecJ5o-0005yz-7O for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 17:55:32 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecJ5f-0005xW-8Y; Thu, 18 Jan 2018 17:55:23 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ecJ5e-0002Tl-LG; Thu, 18 Jan 2018 17:55:22 -0500 X-Spook: AIMSX cryptanalysis Ermes Al Qa'ida CDC CISU Deaths X-Ran: /Yi2n?xK>R+z*d/b-g[yux}=5J:j}&,Wfvy>S:KG^cB&3r@edk>xQNR[X\OC)EB17Z:m{+ X-Hue: magenta X-Attribution: GM In-Reply-To: <83efmnuhgo.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Jan 2018 20:53:11 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142280 Archived-At: Eli Zaretskii wrote: >> If it's not to be fixed then IMO in the meantime configure should >> explicitly reject --with-modules if threads are disabled. > > That'd replace one non-trivial change with another, so I think it's > worse than fixing the problem. You think the following is non-trivial? --- a/configure.ac +++ b/configure.ac @@ -3513,6 +3513,8 @@ case $opsys in *) MODULES_SUFFIX=".so" ;; esac if test "${with_modules}" != "no"; then + test "${threads_enabled}" = "no" && \ + AC_MSG_ERROR([modules currently require threads]) case $opsys in gnu|gnu-linux) LIBMODULES="-ldl"