* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
@ 2021-09-14 10:51 Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 11:29 ` Dmitry Gutov
2021-09-14 14:54 ` Glenn Morris
0 siblings, 2 replies; 10+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-09-14 10:51 UTC (permalink / raw)
To: 50577
Severity: wishlist
My global ~/.config/git/config says:
[commit]
gpgSign = true
My Emacs checkout's local .git/config says:
[commit]
gpgSign = false
Nevertheless, 'make test/vc-tests' sees the following test fail:
--8<---------------cut here---------------start------------->8---
Registering (foo)...
Registering (foo)... done
Mark set
Press C-c C-c when you are done editing.
Enter a change comment. Type C-c C-c when done
Checking in foo...
Test vc-test-git06-version-diff backtrace:
signal(error ("Failed (status 128): git --no-pager commit -m Test...
error("Failed (%s): %s" "status 128" "git --no-pager commit -m Testi
vc-do-command("*vc*" 0 "git" (":(literal)foo") "--no-pager" "commit"
apply(vc-do-command "*vc*" 0 "git" (":(literal)foo") ("--no-pager" "
vc-git-command(nil 0 (":(literal)foo") "commit" "-m" "Testing vc-ver
apply(vc-git-command nil 0 (":(literal)foo") ("commit" "-m" "Testing
vc-git-checkin(("foo") "Summary: Testing vc-version-diff\n" nil)
apply(vc-git-checkin (("foo") "Summary: Testing vc-version-diff\n" n
vc-call-backend(Git checkin ("foo") "Summary: Testing vc-version-dif
#f(compiled-function (files comment) #<bytecode -0x4a430ccb4d2a198>)
vc-finish-logentry()
funcall-interactively(vc-finish-logentry)
call-interactively(vc-finish-logentry)
log-edit-done()
(progn (if (memq backend '(RCS CVS SCCS)) (progn (vc-checkout tmp-na
(save-current-buffer (set-buffer buff) (progn (if (memq backend '(RC
(let ((buff (find-file tmp-name))) (save-current-buffer (set-buffer
(let* ((tmp-name (expand-file-name "foo" default-directory)) (files
(progn (add-hook 'vc-test--cleanup-hook (list 'lambda nil (cons 'del
(unwind-protect (progn (add-hook 'vc-test--cleanup-hook (list 'lambd
(let ((vc-handled-backends (list backend)) (default-directory (file-
vc-test--version-diff(Git)
(lambda nil (let ((value-269 (gensym "ert-form-evaluation-aborted-")
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name vc-test-git06-version-diff :documenta
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
command-line()
normal-top-level()
Test vc-test-git06-version-diff condition:
(error "Failed (status 128): git --no-pager commit -m Testing vc-version-diff\n\n --only -- :(literal)foo")
FAILED 14/21 vc-test-git06-version-diff (0.038991 sec)
--8<---------------cut here---------------end--------------->8---
Disabling my global commit.gpgSign setting allows the test to pass.
How can we protect the test suite from such global settings?
Thanks,
--
Basil
In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
of 2021-09-14 built on tia
Repository revision: 1e83d04214f27a79a4d4841772da946e24cbf21d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux bookworm/sid
Configured using:
'configure 'CC=ccache gcc' 'CFLAGS=-Og -ggdb' --config-cache
--prefix=/home/blc/.local --enable-checking=structs
--with-x-toolkit=lucid --with-file-notification=yes --with-x'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XAW3D XDBE XIM XPM LUCID ZLIB
Important settings:
value of $LANG: en_IE.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo x-toolkit x multi-tty make-network-process emacs)
Memory information:
((conses 16 50683 5829)
(symbols 48 6619 1)
(strings 32 18945 1298)
(string-bytes 1 611959)
(vectors 16 13364)
(vector-slots 8 178283 7678)
(floats 8 23 44)
(intervals 56 230 0)
(buffers 992 10))
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 10:51 bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-09-14 11:29 ` Dmitry Gutov
2021-09-14 19:59 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 14:54 ` Glenn Morris
1 sibling, 1 reply; 10+ messages in thread
From: Dmitry Gutov @ 2021-09-14 11:29 UTC (permalink / raw)
To: Basil L. Contovounesios, 50577
On 14.09.2021 13:51, Basil L. Contovounesios via Bug reports for GNU
Emacs, the Swiss army knife of text editors wrote:
> Disabling my global commit.gpgSign setting allows the test to pass.
> How can we protect the test suite from such global settings?
Is there an environment variable which would disable GPG signing?
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 11:29 ` Dmitry Gutov
@ 2021-09-14 19:59 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 22:36 ` Dmitry Gutov
0 siblings, 1 reply; 10+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-09-14 19:59 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 50577
Dmitry Gutov [2021-09-14 14:29 +0300] wrote:
> On 14.09.2021 13:51, Basil L. Contovounesios via Bug reports for GNU Emacs, the
> Swiss army knife of text editors wrote:
>> Disabling my global commit.gpgSign setting allows the test to pass.
>> How can we protect the test suite from such global settings?
>
> Is there an environment variable which would disable GPG signing?
Not that I know of, but Glenn's suggestion to set XDG_CONFIG_HOME sounds
like TRT.
Thanks,
--
Basil
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 19:59 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-09-14 22:36 ` Dmitry Gutov
2021-09-14 23:40 ` Glenn Morris
2021-09-14 23:52 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 2 replies; 10+ messages in thread
From: Dmitry Gutov @ 2021-09-14 22:36 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 50577
On 14.09.2021 22:59, Basil L. Contovounesios wrote:
> Not that I know of, but Glenn's suggestion to set XDG_CONFIG_HOME sounds
> like TRT.
Could you try adding it yourself, to see that it works?
test/lisp/vc/vc-tests.el, somewhere around line 627.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 22:36 ` Dmitry Gutov
@ 2021-09-14 23:40 ` Glenn Morris
2021-09-15 0:03 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 23:52 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2021-09-14 23:40 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Basil L. Contovounesios, 50577
I think 42b49e9 should suffice.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 23:40 ` Glenn Morris
@ 2021-09-15 0:03 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 10+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-09-15 0:03 UTC (permalink / raw)
To: Glenn Morris; +Cc: 50577, Dmitry Gutov
close 50577 28.1
quit
Glenn Morris [2021-09-14 19:40 -0400] wrote:
> I think 42b49e9 should suffice.
Even better, thanks!
--
Basil
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 22:36 ` Dmitry Gutov
2021-09-14 23:40 ` Glenn Morris
@ 2021-09-14 23:52 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 0 replies; 10+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-09-14 23:52 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 50577
Dmitry Gutov [2021-09-15 01:36 +0300] wrote:
> On 14.09.2021 22:59, Basil L. Contovounesios wrote:
>> Not that I know of, but Glenn's suggestion to set XDG_CONFIG_HOME sounds
>> like TRT.
>
> Could you try adding it yourself, to see that it works?
>
> test/lisp/vc/vc-tests.el, somewhere around line 627.
Setting XDG_CONFIG_HOME there works too, but why not set it for all
tests, like we do with HOME?
I was hoping someone more familiar with test/Makefile.in would beat me
to it, but if not I'll propose a patch soon.
Thanks,
--
Basil
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 10:51 bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 11:29 ` Dmitry Gutov
@ 2021-09-14 14:54 ` Glenn Morris
2021-09-14 14:59 ` Glenn Morris
1 sibling, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2021-09-14 14:54 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 50577
Tests are run with HOME=/nonexistent to avoid just this kind of issue,
so how are settings in your user home directory being found?
(I have wondered if some XDG_ variables(s) also need to be set.)
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 14:54 ` Glenn Morris
@ 2021-09-14 14:59 ` Glenn Morris
2021-09-14 19:55 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2021-09-14 14:59 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 50577
Perhaps you have an explicit XDG_CONFIG_HOME set in your environment,
and perhaps test/Makefile should set (or unset) that variable too.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
2021-09-14 14:59 ` Glenn Morris
@ 2021-09-14 19:55 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 10+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-09-14 19:55 UTC (permalink / raw)
To: Glenn Morris; +Cc: 50577
Glenn Morris [2021-09-14 10:59 -0400] wrote:
> Perhaps you have an explicit XDG_CONFIG_HOME set in your environment,
Yes, my ~/.profile says:
export XDG_CONFIG_HOME="${XDG_CONFIG_HOME:-${HOME}/.config}"
> and perhaps test/Makefile should set (or unset) that variable too.
Indeed, 'make XDG_CONFIG_HOME=/nonexistent test/vc-tests' succeeds.
Thanks,
--
Basil
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-09-15 0:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-14 10:51 bug#50577: 28.0.50; Check-in fails in VC tests with commit.gpgSign true Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 11:29 ` Dmitry Gutov
2021-09-14 19:59 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 22:36 ` Dmitry Gutov
2021-09-14 23:40 ` Glenn Morris
2021-09-15 0:03 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 23:52 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 14:54 ` Glenn Morris
2021-09-14 14:59 ` Glenn Morris
2021-09-14 19:55 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.