* sh-mode buglet
@ 2006-02-24 18:37 Giorgos Keramidas
2006-02-25 11:27 ` Thien-Thi Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Giorgos Keramidas @ 2006-02-24 18:37 UTC (permalink / raw)
The head version of sh-script.el has a minor buglet that prevents one
from running:
% emacs -f sh-mode
to fire up Emacs in sh-mode.
The debugger backtrace is:
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
string-match("[.]sh\\>" nil)
sh-mode()
eval((sh-mode))
eval-last-sexp-1((4))
eval-last-sexp((4))
call-interactively(eval-last-sexp)
and it looks like this is what would be needed:
% Index: lisp/progmodes/sh-script.el
% ===================================================================
% --- lisp/progmodes/sh-script.el (revision 45)
% +++ lisp/progmodes/sh-script.el (working copy)
% @@ -1438,7 +1438,7 @@
% ((and buffer-file-name
% (string-match "\\.m?spec\\'" buffer-file-name))
% "rpm")))))
% - (unless interpreter
% + (unless (or interpreter (null buffer-file-name))
% (setq interpreter
% (cond ((string-match "[.]sh\\>" buffer-file-name)
% "sh")
I haven't had a chance to build a snapshot with this change yet,
but has anyone else used sh-mode and seen this? Does the change
look reasonable?
- Giorgos
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sh-mode buglet
2006-02-24 18:37 sh-mode buglet Giorgos Keramidas
@ 2006-02-25 11:27 ` Thien-Thi Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Thien-Thi Nguyen @ 2006-02-25 11:27 UTC (permalink / raw)
Cc: emacs-devel
Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> string-match("[.]sh\\>" nil)
> sh-mode()
> eval((sh-mode))
> eval-last-sexp-1((4))
> eval-last-sexp((4))
> call-interactively(eval-last-sexp)
>
> I haven't had a chance to build a snapshot with this change yet,
> but has anyone else used sh-mode and seen this? Does the change
> look reasonable?
thanks for reporting this. i installed a (different) fix.
thi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-25 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-24 18:37 sh-mode buglet Giorgos Keramidas
2006-02-25 11:27 ` Thien-Thi Nguyen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.