all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thien-Thi Nguyen <ttn@glug.org>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: RMAIL, summary/message focus switching with `h' button
Date: 12 Feb 2003 19:01:54 -0500	[thread overview]
Message-ID: <jk65rpjbf1.fsf@glug.org> (raw)
In-Reply-To: Alexander Pohoyda's message of "Wed, 12 Feb 2003 22:13:14 +0100 (CET)"

Alexander Pohoyda <alexander.pohoyda@gmx.net> writes:

   +  (let (was-in-summary)
   +    (if (eq major-mode 'rmail-summary-mode)
   +       (setq was-in-summary t))
   +    (rmail-new-summary "All" '(rmail-summary) nil)
   +    ;; Swap the focus.
   +    (if was-in-summary
   +       (other-window 1))))

a minor style nit, that does not address the suitability of the patch:

you can tighten the binding construct to something like:

   (let ((was-in-summary (eq major-mode 'rmail-summary-mode)))
      ...)

this is because `eq' is a predicate and `was-in-summary' is used as a
predicate var.  also, in the combined form `setq' is unnecessary.

thi

  reply	other threads:[~2003-02-13  0:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-12 21:13 RMAIL, summary/message focus switching with `h' button Alexander Pohoyda
2003-02-13  0:01 ` Thien-Thi Nguyen [this message]
2003-02-13  6:24   ` Alexander Pohoyda
2003-02-13  9:27     ` Andreas Schwab
2003-02-13  9:37       ` Alexander Pohoyda
2003-02-13 10:51         ` Andreas Schwab
2003-02-13 16:13           ` Alexander Pohoyda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jk65rpjbf1.fsf@glug.org \
    --to=ttn@glug.org \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.