From: joaotavora@gmail.com (João Távora)
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Akira Kitada <akitada@gmail.com>, Tassilo Horn <tsdh@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Getting rid of low-level assumptions in yasnippet
Date: Fri, 20 Mar 2015 11:03:20 +0000 [thread overview]
Message-ID: <jjbzj78c4nb.fsf@gmail.com> (raw)
In-Reply-To: <jwvwq2c3h69.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 19 Mar 2015 15:49:59 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> Could you double check the patch below, to make sure it does the right thing?
> The main thrust is to get rid of the use of the `cl-struct-slots'
> property which doesn't exist in Emacs-25 any more.
The patch look good. I've pushed it upstream and it passes all
tests. I'm slightly embarassed you have to wade through that junk, but
that's how much Lisp I knew at the time.
> This is against the elpa.git version of the code, which IIUC is still
> not up-to-date, right?
Again embarassing: there are two or three issues on the upstream side
also pending on this move. I'll try to do this later today.
One thing I don't know how to handle is the Git submodules which are
problematic for some (unofficial) uses of ELPA.git, such as
https://github.com/quelpa/quelpa (CCing akira)
So unless you disagree, I'll remove them completely in the subtree merge
result and (temporarily) replace yasnippet/snippets with a copy of the
old snippet collection.
João
next prev parent reply other threads:[~2015-03-20 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:49 Getting rid of low-level assumptions in yasnippet Stefan Monnier
2015-03-20 11:03 ` João Távora [this message]
2015-03-20 14:18 ` Stefan Monnier
2015-03-28 15:59 ` João Távora
2015-03-28 20:32 ` Stefan Monnier
2015-03-28 21:23 ` João Távora
2015-03-29 19:36 ` Matthew Fidler
2015-03-30 0:47 ` Stefan Monnier
2015-03-30 15:15 ` Matthew Fidler
2015-03-30 18:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jjbzj78c4nb.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=akitada@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.