From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f
Date: Mon, 14 Jan 2019 17:11:58 +0000 [thread overview]
Message-ID: <jjb1s5fw4dd.fsf@gmail.com> (raw)
In-Reply-To: <83d0ozdwfz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Jan 2019 18:40:32 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: João Távora <joaotavora@gmail.com>
>> Cc: Drew Adams <drew.adams@oracle.com>, 34070@debbugs.gnu.org, monnier@iro.umontreal.ca
>> Date: Mon, 14 Jan 2019 16:25:41 +0000
>>
>> > Please add a test for this, if possible, so that we don't screw this
>> > up again in the future.
>>
>> I'd love to, but it's not exactly simple to write tests that observe
>> user interaction the minibuffer with ert. At least for me. How would I
>> go about doing that? Any pointers/prior art?
>
> (A stab in the dark) invoke the function bound to TAB and examine what
> it produces?
:-)
Where do you mean TAB? It's not even in the recipe. Well I though
about it a bit and can probalby use minibuffer-setup-hook
(let ((minibuffer-setup-hook
(append minibuffer-setup-hook
(list (lambda ()
;; commands and observations
))))
(default-directory source-directory))
(find-file-read-args "Find file: " (confirm-nonexistent-file-or-buffer)))
Don't know how to observe the icomplete candidates though, but this
strategy is probably enough to make a test. I'd like to push the fix
before that maybe, any objections?
João
next prev parent reply other threads:[~2019-01-14 17:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 13:47 bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f João Távora
2019-01-14 16:03 ` Eli Zaretskii
2019-01-14 16:25 ` João Távora
2019-01-14 16:40 ` Eli Zaretskii
2019-01-14 17:11 ` João Távora [this message]
2019-01-14 17:40 ` Eli Zaretskii
2019-01-14 17:51 ` João Távora
2019-01-14 17:55 ` Drew Adams
2019-01-17 14:20 ` João Távora
2019-01-17 15:00 ` Stefan Monnier
2019-01-17 15:22 ` João Távora
2019-01-17 15:46 ` Drew Adams
2019-01-17 15:55 ` Stefan Monnier
2019-01-17 15:55 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jjb1s5fw4dd.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=34070@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.