From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: 23.0.60; read-char unexpectedly halts execution of script Date: Mon, 06 Oct 2008 23:28:06 +0200 Message-ID: References: <87hc7pr16r.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1223328551 10383 80.91.229.12 (6 Oct 2008 21:29:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Oct 2008 21:29:11 +0000 (UTC) Cc: 1082@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 06 23:30:09 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kmxea-0002lz-J1 for ged-emacs-devel@m.gmane.org; Mon, 06 Oct 2008 23:30:08 +0200 Original-Received: from localhost ([127.0.0.1]:46011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KmxdX-0001Ib-0A for ged-emacs-devel@m.gmane.org; Mon, 06 Oct 2008 17:29:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kmxcj-0000pO-KZ for emacs-devel@gnu.org; Mon, 06 Oct 2008 17:28:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kmxci-0000oN-9I for emacs-devel@gnu.org; Mon, 06 Oct 2008 17:28:13 -0400 Original-Received: from [199.232.76.173] (port=53697 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kmxch-0000o8-VK for emacs-devel@gnu.org; Mon, 06 Oct 2008 17:28:12 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]:49083) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kmxch-0007yi-GM for emacs-devel@gnu.org; Mon, 06 Oct 2008 17:28:11 -0400 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id D512D45BF1; Mon, 6 Oct 2008 23:28:07 +0200 (CEST) X-Yow: Two with FLUFFO, hold th' BEETS..side of SOYETTES! In-Reply-To: <87hc7pr16r.fsf@cyd.mit.edu> (Chong Yidong's message of "Mon, 06 Oct 2008 15:08:44 -0400") User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104387 Archived-At: Chong Yidong writes: >> Let filter.el consist of the forms: >> >> (defun bc-filter (proc string) >> (message "%s" string)) >> >> (message "starting") >> (setq bc (start-process "bc" nil "/usr/bin/bc")) >> (set-process-filter bc 'bc-filter) >> >> (while t >> (let ((char (read-char nil nil 0.1))) >> (message "char: %s" char))) >> >> Where "/usr/bin/bc" is the GNU arbitrary precision calculator. Now: >> >> mt-computer:~ mt$ emacs --script filter.el >> starting >> mt-computer:~ mt$ >> >> I expect non-termination in this case, as in eval-buffer on filter.el. > > This broke when SYNC_INPUT became the default; it works when Emacs is > recompiled without SYNC_INPUT, like Emacs 22. > > I don't know what the specific cause of failure is, however. Maybe the > SYNC_INPUT code should only be active when Emacs is run interactively. > > Thoughts? In non-interactive mode we always want restartable syscalls, since keyboard input goes through stdio (SYNC_INPUT makes no difference here). I've checked in a fix. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."