From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: strange change in store_symval_forwarding (data.c) Date: Wed, 26 Mar 2003 15:41:05 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200303260253.LAA08706@etlken.m17n.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1048690937 29670 80.91.224.249 (26 Mar 2003 15:02:17 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 26 Mar 2003 15:02:17 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Mar 26 16:02:14 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18yCPu-0007i8-00 for ; Wed, 26 Mar 2003 16:02:14 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18yCRL-0002cR-00 for ; Wed, 26 Mar 2003 16:03:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18yCNd-0006bA-08 for emacs-devel@quimby.gnus.org; Wed, 26 Mar 2003 09:59:53 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18yCFL-0002U4-00 for emacs-devel@gnu.org; Wed, 26 Mar 2003 09:51:19 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18yCEU-0002G2-00 for emacs-devel@gnu.org; Wed, 26 Mar 2003 09:50:27 -0500 Original-Received: from ns.suse.de ([213.95.15.193] helo=Cantor.suse.de) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18yC5W-0007Cf-00 for emacs-devel@gnu.org; Wed, 26 Mar 2003 09:41:10 -0500 Original-Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136]) by Cantor.suse.de (Postfix) with ESMTP id 1DEF614A1F; Wed, 26 Mar 2003 15:41:06 +0100 (MET) Original-To: Kenichi Handa X-Yow: My pants just went to high school in the Carlsbad Caverns!!! In-Reply-To: <200303260253.LAA08706@etlken.m17n.org> (Kenichi Handa's message of "Wed, 26 Mar 2003 11:53:58 +0900 (JST)") User-Agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12634 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12634 Kenichi Handa writes: |> Currently, store_symval_forwarding has this code: |> |> case Lisp_Misc_Buffer_Objfwd: |> { |> int offset = XBUFFER_OBJFWD (valcontents)->offset; |> Lisp_Object type; |> |> if (! NILP (type) && ! NILP (newval) |> && XTYPE (newval) != XINT (type)) |> buffer_slot_type_mismatch (offset); |> |> Please note that the local variable `type' is used without |> being initialized. |> |> Previously, the code has this initilization part: |> |> Lisp_Object type; |> |> type = PER_BUFFER_TYPE (offset); |> if (XINT (type) == -1) |> error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol))); |> |> ChangeLog doesn't say anything about this change, but it |> seems that it was done when this change was installed. |> |> 2003-03-13 Andreas Schwab |> [...] |> * data.c (long_to_cons): Fix type of top. |> |> Andreas, do you know somthing about it? This code was already like this in revision 1.219, ie. before my change. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."