all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Recent change to xfns.c breaks compilation
@ 2003-07-15  0:10 Markus Rost
  2003-07-16 10:31 ` Richard Stallman
  0 siblings, 1 reply; 12+ messages in thread
From: Markus Rost @ 2003-07-15  0:10 UTC (permalink / raw)
  Cc: emacs-devel


   This change:

   2003-07-12  Richard M. Stallman  <rms@bogus.example.com>

	   * xfns.c: Include libpng/png.h instead of png.h.

   causes problems on my GNU/Linux system (redhat 6.2) where png.h is in
   /usr/include.

   What is the rationale for that change?


   Since configure only checks for the presence of png.h (and not
   libpng/png.h), I think we need to check for both and condition the
   #include with HAVE_PNG_H and HAVE_LIBPNG_PNG_H.

It still breaks compilation for me, on gnu/linux and solaris.
Moreover autoconf does not work well after the recent change

2003-07-12  Richard M. Stallman  <rms@gnu.org>

	* configure.in [netbsd systems]: Define HAVE_CRTIN properly.

Here are some lines from the shell:

gcc -c -D_BSD_SOURCE   -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/home/rost/cvs-gnu-linux1/emacs/src -D_BSD_SOURCE -I/usr/X11R6/include -g xfns.c
xfns.c:7568:24: libpng/png.h: No such file or directory
make[1]: *** [xfns.o] Error 1
make[1]: Leaving directory `/home/rost/cvs-gnu-linux1/emacs/src'
make: *** [bootstrap] Error 2

euler:~/cvs-gnu-linux1/emacs> autoconf
configure.in:50: error: possibly undefined macro: AC_DEFINE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

euler:~/cvs-gnu-linux1/emacs> autoconf --version
autoconf (GNU Autoconf) 2.57

euler:~/cvs-gnu-linux1/emacs> configure
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
./configure: line 1666: syntax error near unexpected token `AC_DEFINE(HAVE_CRTIN)'
./configure: line 1666: `      AC_DEFINE(HAVE_CRTIN)'

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Recent change to xfns.c breaks compilation
@ 2003-07-13  1:23 Kim F. Storm
       [not found] ` <E19bkkG-0005iJ-Ak@fencepost.gnu.org>
  0 siblings, 1 reply; 12+ messages in thread
From: Kim F. Storm @ 2003-07-13  1:23 UTC (permalink / raw)
  Cc: emacs-devel


This change:

2003-07-12  Richard M. Stallman  <rms@gnu.org>

	* xfns.c: Include libpng/png.h instead of png.h.

causes problems on my GNU/Linux system (redhat 6.2) where png.h is in
/usr/include.

What is the rationale for that change?


Since configure only checks for the presence of png.h (and not
libpng/png.h), I think we need to check for both and condition the
#include with HAVE_PNG_H and HAVE_LIBPNG_PNG_H.


-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2003-07-23 23:03 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-07-15  0:10 Recent change to xfns.c breaks compilation Markus Rost
2003-07-16 10:31 ` Richard Stallman
2003-07-16 11:56   ` Andreas Schwab
2003-07-17 10:10     ` Richard Stallman
2003-07-17 10:19       ` David Kastrup
2003-07-17 11:15       ` Andreas Schwab
2003-07-17 14:38       ` Markus Rost
  -- strict thread matches above, loose matches on Subject: below --
2003-07-13  1:23 Kim F. Storm
     [not found] ` <E19bkkG-0005iJ-Ak@fencepost.gnu.org>
     [not found]   ` <5xwuekaekd.fsf@kfs2.cua.dk>
2003-07-15 11:02     ` Richard Stallman
2003-07-20 23:06     ` Richard Stallman
2003-07-22 19:12       ` Kai Großjohann
2003-07-23 23:03         ` Richard Stallman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.