From: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: Re: strange change in store_symval_forwarding (data.c)
Date: Wed, 26 Mar 2003 15:51:53 +0100 [thread overview]
Message-ID: <jer88urxiu.fsf@sykes.suse.de> (raw)
In-Reply-To: <200303260253.LAA08706@etlken.m17n.org> (Kenichi Handa's message of "Wed, 26 Mar 2003 11:53:58 +0900 (JST)")
Kenichi Handa <handa@m17n.org> writes:
|> Currently, store_symval_forwarding has this code:
|>
|> case Lisp_Misc_Buffer_Objfwd:
|> {
|> int offset = XBUFFER_OBJFWD (valcontents)->offset;
|> Lisp_Object type;
|>
|> if (! NILP (type) && ! NILP (newval)
|> && XTYPE (newval) != XINT (type))
|> buffer_slot_type_mismatch (offset);
|>
|> Please note that the local variable `type' is used without
|> being initialized.
|>
|> Previously, the code has this initilization part:
|>
|> Lisp_Object type;
|>
|> type = PER_BUFFER_TYPE (offset);
|> if (XINT (type) == -1)
|> error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
|>
|> ChangeLog doesn't say anything about this change, but it
|> seems that it was done when this change was installed.
This was changed as part of Stefan's checkin (revision 1.221), which does
not have a ChangeLog entry (yet).
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2003-03-26 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 2:53 strange change in store_symval_forwarding (data.c) Kenichi Handa
2003-03-26 14:41 ` Andreas Schwab
2003-03-26 14:51 ` Andreas Schwab [this message]
2003-03-27 0:58 ` Kenichi Handa
2003-03-26 15:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jer88urxiu.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.