From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: kill-buffer-if-not-modified: Wrong type argument: bufferp, t Date: Mon, 21 Jan 2008 20:55:20 +0100 Message-ID: References: <87fxwrc92i.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1200945376 13656 80.91.229.12 (21 Jan 2008 19:56:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Jan 2008 19:56:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sven Joachim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 21 20:56:35 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JH2l0-0002hF-Og for ged-emacs-devel@m.gmane.org; Mon, 21 Jan 2008 20:56:35 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH2kb-0005ob-Ay for ged-emacs-devel@m.gmane.org; Mon, 21 Jan 2008 14:56:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JH2ju-0005TJ-VQ for emacs-devel@gnu.org; Mon, 21 Jan 2008 14:55:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JH2jt-0005Su-J5 for emacs-devel@gnu.org; Mon, 21 Jan 2008 14:55:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH2jt-0005Sp-BG for emacs-devel@gnu.org; Mon, 21 Jan 2008 14:55:25 -0500 Original-Received: from ns.suse.de ([195.135.220.2] helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JH2js-0001Dl-ON for emacs-devel@gnu.org; Mon, 21 Jan 2008 14:55:24 -0500 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 4F1F126C3C; Mon, 21 Jan 2008 20:55:21 +0100 (CET) X-Yow: ...I think I'm having an overnight sensation right now!! In-Reply-To: <87fxwrc92i.fsf@gmx.de> (Sven Joachim's message of "Mon\, 21 Jan 2008 19\:44\:37 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87231 Archived-At: Sven Joachim writes: > --- view.el 21 Jan 2008 18:51:02 +0100 1.84.2.9 > +++ view.el 21 Jan 2008 19:26:10 +0100=09 > @@ -244,7 +244,9 @@ > ;; types C-x C-q again to return to view mode. > (defun kill-buffer-if-not-modified (buf) > "Like `kill-buffer', but does nothing if the buffer is modified." > - (let ((buf (or (bufferp buf) (get-buffer buf)))) > + (let ((buf (if (bufferp buf) > + buf > + (get-buffer buf)))) get-buffer returns the argument if it is already a buffer, thus the conditional is not needed. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."