From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: shell-command - missing shell-quote-argument for program? Date: Sat, 14 Oct 2006 19:50:01 +0200 Message-ID: References: <452517DC.5010007@student.lu.se> <45251C56.8010603@student.lu.se> <4531032D.6060708@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1160848240 5329 80.91.229.2 (14 Oct 2006 17:50:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2006 17:50:40 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org, Carsten Dominik Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 14 19:50:38 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GYnec-0003h1-Lw for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2006 19:50:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GYnec-0006Jr-8E for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2006 13:50:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GYneJ-0006E1-Gk for emacs-devel@gnu.org; Sat, 14 Oct 2006 13:50:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GYneH-00065C-3D for emacs-devel@gnu.org; Sat, 14 Oct 2006 13:50:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GYneG-00064U-QZ for emacs-devel@gnu.org; Sat, 14 Oct 2006 13:50:12 -0400 Original-Received: from [195.135.220.15] (helo=mx2.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GYnmx-0000AW-3b; Sat, 14 Oct 2006 13:59:11 -0400 Original-Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 5CC2421419; Sat, 14 Oct 2006 19:50:04 +0200 (CEST) Original-To: Lennart Borgman X-Yow: Vote for ME -- I'm well-tapered, half-cocked, ill-conceived and TAX-DEFERRED! In-Reply-To: <4531032D.6060708@student.lu.se> (Lennart Borgman's message of "Sat, 14 Oct 2006 17:33:01 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60744 Archived-At: Lennart Borgman writes: > Index: ada-xref.el > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvsroot/emacs/emacs/lisp/progmodes/ada-xref.el,v > retrieving revision 1.26 > diff -c -r1.26 ada-xref.el > *** ada-xref.el 10 Feb 2006 09:00:31 -0000 1.26 > --- ada-xref.el 11 Oct 2006 22:55:48 -0000 > *************** > *** 1916,1923 **** > (set-buffer (get-buffer-create "*grep*")) > (while dirs > (insert (shell-command-to-string > ! (concat "egrep -i -h '^X|" regexp "( |$)' " > ! (file-name-as-directory (car dirs)) "*.ali"))) > (set 'dirs (cdr dirs))) > > ;; Now parse the output > --- 1916,1926 ---- > (set-buffer (get-buffer-create "*grep*")) > (while dirs > (insert (shell-command-to-string > ! (concat "egrep -i -h '^X|" > ! (shell-quote-argument regexp) This is wrong, the argument is already enclosed in single quotes. There is no need for further quoting, since the regexp cannot contain single quotes (it is constructed from an Ada identifier). Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."