Re: unicode build: "comparison is always true" warnings

[Andreas Schwab <schwab@suse.de>]

mah@everybody.org (Mark A. Hershberger) writes:

>        while (1)
>  	{
>  	  /* Create the lock file, but not under the lock file name.  */
>  	  /* Give up if cannot do that.  */
> +#ifndef HAVE_MKSTEMP
>  	  desc = open (tempname, O_WRONLY | O_CREAT | O_EXCL, 0666);
> +#else
> +          desc = mkstemp (tempname);
> +#endif

That won't work since mkstemp modifies tempname in place, but can be
called more than once here (the second call will return with EINVAL).

(The use of mktemp is not really bad here anyway.)

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."