Re: Bug in copy-file

[Andreas Schwab <schwab@suse.de>]

Lars Hansen <larsh@math.ku.dk> writes:

|> Andreas Schwab wrote:
|> 
|> >Lars Hansen <larsh@math.ku.dk> writes:
|> >
|> >|> A bug has been introduced since Emacs 21.2.
|> >|> A "!" has been added where it should not be.
|> >|> As a consequence the keep-time parameter functions
|> >|> opposite of what is intended. The patch below
|> >|> should fix the problem.
|> >
|> >Why do you think so?  The use of keep-time is correct according to the
|> >doc string.
|> >
|> >Andreas.
|> >
|> Maybe I am misreading the code or the doc string. I read them like this:
|> Doc string says:
|> 
|>     Fourth arg KEEP-TIME non-nil means give the new file the same
|>     last-modified time as the old one.
|> 
|> But when keep_time is non-nil, NILP (keep_time) is false, so !NILP
|> (keep_time)
|> is true. Thus the code following if (NILP (keep_time)) is entered. In
|> this code it
|> reads
|> 
|>        EMACS_GET_TIME (now);
|> 
|> and
|> 
|>        if (set_file_times (filename, now, now))
|> 
|> so the time is set to now, not kept.
|> 
|> Am I wrong?

No, you are right.  I didn't know that windows is backwards.

|> By the way, it is easy to test: Just do eg:

You first need to install a proprietary operating system, which is a very
difficult and expensive part.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."