From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: busyloop in sigchld_handler Date: Wed, 28 Mar 2007 17:25:08 +0200 Message-ID: References: <87slbpo0pk.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1175095525 13820 80.91.229.12 (28 Mar 2007 15:25:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Mar 2007 15:25:25 +0000 (UTC) Cc: emacs-devel@gnu.org, "Kim F. Storm" To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 28 17:25:18 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HWa1V-0005wq-LC for ged-emacs-devel@m.gmane.org; Wed, 28 Mar 2007 17:25:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HWa3z-0000p5-2B for ged-emacs-devel@m.gmane.org; Wed, 28 Mar 2007 10:27:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HWa3v-0000oq-3w for emacs-devel@gnu.org; Wed, 28 Mar 2007 11:27:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HWa3t-0000oe-UP for emacs-devel@gnu.org; Wed, 28 Mar 2007 11:27:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HWa3t-0000ob-Qh for emacs-devel@gnu.org; Wed, 28 Mar 2007 10:27:45 -0500 Original-Received: from mx2.suse.de ([195.135.220.15]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HWa1P-00085s-Fc for emacs-devel@gnu.org; Wed, 28 Mar 2007 11:25:11 -0400 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 48512215B6; Wed, 28 Mar 2007 17:25:09 +0200 (CEST) X-Yow: I joined scientology at a garage sale!! In-Reply-To: <87slbpo0pk.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 28 Mar 2007 11:19:03 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68713 Archived-At: Chong Yidong writes: >> Do all platforms have usleep ? > > usleep is not in POSIX, so we can't assume it exists. > >> Otherwise, we need a check in configure and use >> >> #ifdef HAVE_USLEEP >> usleep(1000); >> #endif > > ... or we could use nanosleep, which is in POSIX. We should probably just remove the loop altogether. --- process.c 28 M=E4r 2007 12:54:58 +0200 1.508 +++ process.c 28 M=E4r 2007 16:19:54 +0200=09 @@ -6499,18 +6499,7 @@ sigchld_handler (signo) #ifndef WUNTRACED #define WUNTRACED 0 #endif /* no WUNTRACED */ - /* Keep trying to get a status until we get a definitive result. = */ - do - { - /* For some reason, this sleep() prevents Emacs from sending - loadavg to 5-8(!) for ~10 seconds. - See http://thread.gmane.org/gmane.emacs.devel/67722 or - http://www.google.com/search?q=3Dbusyloop+in+sigchld_handle= r */ - usleep (1000); - errno =3D 0; - pid =3D wait3 (&w, WNOHANG | WUNTRACED, 0); - } - while (pid < 0 && errno =3D=3D EINTR); + pid =3D wait3 (&w, WNOHANG | WUNTRACED, 0); =20 if (pid <=3D 0) { Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."