From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: void variable Date: Thu, 19 Aug 2004 23:54:33 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <410353ED.1090107@math.ku.dk> <4104091E.4040007@math.ku.dk> <200407252046.i6PKkFH29813@raven.dms.auburn.edu> <200407262041.i6QKfFu15523@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1092952553 9870 80.91.224.253 (19 Aug 2004 21:55:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 19 Aug 2004 21:55:53 +0000 (UTC) Cc: larsh@math.ku.dk, Luc Teirlinck , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 19 23:55:46 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bxuss-0002UY-00 for ; Thu, 19 Aug 2004 23:55:46 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bxux9-0003hj-1D for ged-emacs-devel@m.gmane.org; Thu, 19 Aug 2004 18:00:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bxuwt-0003gJ-3J for emacs-devel@gnu.org; Thu, 19 Aug 2004 17:59:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bxuwr-0003fj-Dh for emacs-devel@gnu.org; Thu, 19 Aug 2004 17:59:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bxuwr-0003fL-87 for emacs-devel@gnu.org; Thu, 19 Aug 2004 17:59:53 -0400 Original-Received: from [195.135.220.2] (helo=Cantor.suse.de) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1Bxurm-0007uF-QT; Thu, 19 Aug 2004 17:54:39 -0400 Original-Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 5D844AA846C; Thu, 19 Aug 2004 23:54:35 +0200 (CEST) Original-To: Stefan Monnier X-Yow: .. I see TOILET SEATS... In-Reply-To: (Stefan Monnier's message of "19 Aug 2004 15:33:53 -0400") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26331 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26331 Stefan Monnier writes: > --- orig/src/eval.c > +++ mod/src/eval.c > @@ -747,6 +747,20 @@ > XSYMBOL (sym)->constant =3D 0; > if (NILP (tem)) > Fset_default (sym, Feval (Fcar (tail))); > + else > + { /* Check if there is really a global binding rather than just a let > + binding that shadows the global unboundness of the var. */ > + struct specbinding *pdl =3D specpdl_ptr; > + while (--pdl >=3D specpdl) > + { > + if (!pdl->func && EQ (pdl->symbol, sym) && EQ (pdl->old_value, = Qunbound)) > + { > + message_with_string ("%s is still globally unbound", > + SYMBOL_NAME (sym), 1); > + pdl =3D specpdl; /* Don'tlook further. */ What's wrong with break here? Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."