From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: [patch] fix for the gcc -O3 miscompilation Date: Mon, 21 Aug 2006 10:56:13 +0200 Message-ID: References: <20060819112928.06011846@holly.localdomain> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1156150623 12843 80.91.229.2 (21 Aug 2006 08:57:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 21 Aug 2006 08:57:03 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 21 10:57:02 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GF5aX-0001rG-Fb for ged-emacs-devel@m.gmane.org; Mon, 21 Aug 2006 10:56:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GF5aW-0006bk-ST for ged-emacs-devel@m.gmane.org; Mon, 21 Aug 2006 04:56:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GF5a0-0006Vi-5E for emacs-devel@gnu.org; Mon, 21 Aug 2006 04:56:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GF5Zx-0006S5-93 for emacs-devel@gnu.org; Mon, 21 Aug 2006 04:56:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GF5Zw-0006Rm-GE for emacs-devel@gnu.org; Mon, 21 Aug 2006 04:56:16 -0400 Original-Received: from [195.135.220.15] (helo=mx2.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GF5hH-0000ZA-Rh for emacs-devel@gnu.org; Mon, 21 Aug 2006 05:03:52 -0400 Original-Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 0AB5420143; Mon, 21 Aug 2006 10:56:14 +0200 (CEST) Original-To: Jindrich Makovicka X-Yow: BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI-BI- In-Reply-To: <20060819112928.06011846@holly.localdomain> (Jindrich Makovicka's message of "Sat, 19 Aug 2006 11:29:28 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58597 Archived-At: Jindrich Makovicka writes: > the attached patch fixes the long standing breakage when compiling > emacs with newer gcc and -O3 flag. The problem is that -O3 enables > automatic function inlining, which optimizes out the arguments for > the function invocations within eval.c and fns.c, but the functions > expect these values on stack. Adding the "noinline" attribute to these > functions used within eval.c of fns.c seems to solve the problem. IMHO it would be much cleaner to define NO_ARG_ARRAY for all configurations (effectively removing the option). Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."