XSET and XUINT definitions in src/s/*.h

XSET and XUINT definitions in src/s/*.h

[Dan Nicolaescu]

A few files in src/s/ define XSET and XUINT.  The code seems be the
remains of old boilerplate code... 

Should src/s/*.h mess with these macros?

Re: XSET and XUINT definitions in src/s/*.h

[Stefan Monnier]

> A few files in src/s/ define XSET and XUINT.  The code seems be the
> remains of old boilerplate code... 

> Should src/s/*.h mess with these macros?

Preferably not.  IIRC last time I looked at it, I left them as they are
because I couldn't convince myself that the default ones would
also DTRT.  Basically, we'd need someone who knows thoe platforms and/or
can try them.


        Stefan

Re: XSET and XUINT definitions in src/s/*.h

[Andreas Schwab]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> A few files in src/s/ define XSET and XUINT.  The code seems be the
>> remains of old boilerplate code... 
>
>> Should src/s/*.h mess with these macros?

Currently only src/m/*.h do.

> Preferably not.  IIRC last time I looked at it, I left them as they are
> because I couldn't convince myself that the default ones would
> also DTRT.  Basically, we'd need someone who knows thoe platforms and/or
> can try them.

With USE_LSB_TAG the macros are (re-)defined unconditionally anyway.
For the non-USE_LSB_TAG case the machine dependent definitions are
probably still useful.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."