From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Fixing numerous `message' bugs.. Date: Mon, 10 Dec 2007 20:56:05 +0100 Message-ID: References: <87myso8yrs.fsf@marie.gnufans.net> <87ve7b4xt6.fsf@marie.gnufans.net> <85abonpxnw.fsf@lola.goethe.zz> <85fxyel8o8.fsf@lola.goethe.zz> <87hciugzal.fsf@marie.gnufans.net> <87ir36o3as.fsf@marie.gnufans.net> <475D7F91.80503@gnu.org> <877ijmmkuq.fsf@marie.gnufans.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1197316594 29547 80.91.229.12 (10 Dec 2007 19:56:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Dec 2007 19:56:34 +0000 (UTC) Cc: emacs-devel@gnu.org, Jason Rumney To: Dave Goel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 10 20:56:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J1ok1-0007F0-Gu for ged-emacs-devel@m.gmane.org; Mon, 10 Dec 2007 20:56:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1ojj-0006wR-Jw for ged-emacs-devel@m.gmane.org; Mon, 10 Dec 2007 14:56:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J1ojf-0006tp-UD for emacs-devel@gnu.org; Mon, 10 Dec 2007 14:56:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J1oje-0006pW-7J for emacs-devel@gnu.org; Mon, 10 Dec 2007 14:56:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1oje-0006pC-4Y for emacs-devel@gnu.org; Mon, 10 Dec 2007 14:56:14 -0500 Original-Received: from ns.suse.de ([195.135.220.2] helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J1ojZ-00012a-NU; Mon, 10 Dec 2007 14:56:10 -0500 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 6B749229C0; Mon, 10 Dec 2007 20:56:06 +0100 (CET) X-Yow: Do you guys know we just passed thru a BLACK HOLE in space? In-Reply-To: <877ijmmkuq.fsf@marie.gnufans.net> (Dave Goel's message of "Mon\, 10 Dec 2007 14\:05\:17 -0500") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84972 Archived-At: Dave Goel writes: > if (Fequal(args[0],Qt)) Fequal returns a Lisp object, either Qt or Qnil, both of which are always non-zero. To convert it to a boolean you need to use NILP (compiling with USE_LISP_UNION_TYPE helps finding such bugs). But you want to use EQ instead anyway, since you are comparing with a symbol. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."