From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; Crash in ediff-regions-linewise Date: Sun, 14 Oct 2007 22:01:18 +0200 Message-ID: References: <87wstq5cr6.fsf@candyboy.here> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1192392214 16446 80.91.229.12 (14 Oct 2007 20:03:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2007 20:03:34 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Toby Allsopp , rms@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 14 22:03:24 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ih9f6-0001Ui-GW for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 22:02:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih9ez-0002Ji-Tl for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 16:02:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ih9ea-00021H-CK for emacs-devel@gnu.org; Sun, 14 Oct 2007 16:01:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ih9eX-0001ys-Ri for emacs-devel@gnu.org; Sun, 14 Oct 2007 16:01:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih9eX-0001yi-H5 for emacs-devel@gnu.org; Sun, 14 Oct 2007 16:01:33 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih9eX-0004jq-8E for emacs-devel@gnu.org; Sun, 14 Oct 2007 16:01:33 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih9eW-0002Bt-Ls for emacs-pretest-bug@gnu.org; Sun, 14 Oct 2007 16:01:32 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ih9eT-0004j2-LI for emacs-pretest-bug@gnu.org; Sun, 14 Oct 2007 16:01:33 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ih9eT-0004iO-5C; Sun, 14 Oct 2007 16:01:29 -0400 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 028FB22D7C; Sun, 14 Oct 2007 22:01:23 +0200 (CEST) X-Yow: I haven't been married in over six years, but we had sexual counseling every day from Oral Roberts!! In-Reply-To: (Stefan Monnier's message of "Sun\, 14 Oct 2007 15\:05\:16 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80863 gmane.emacs.pretest.bugs:20130 Archived-At: Stefan Monnier writes: > --- buffer.c 10 oct 2007 11:29:34 -0400 1.535 > +++ buffer.c 14 oct 2007 15:03:35 -0400=09 > @@ -568,6 +568,7 @@ > =20 > b =3D (struct buffer *) allocate_buffer (); > b->size =3D sizeof (struct buffer) / sizeof (EMACS_INT); > + XSETPVECTYPE (b, PVEC_BUFFER); Wouldn't it be better to move the last two lines into allocate_buffer? Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."