From: Andreas Schwab <schwab@suse.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-pretest-bug@gnu.org, Toby Allsopp <toby@mi6.gen.nz>, rms@gnu.org
Subject: Re: 23.0.50; Crash in ediff-regions-linewise
Date: Sun, 14 Oct 2007 22:01:18 +0200 [thread overview]
Message-ID: <je8x6531pt.fsf@sykes.suse.de> (raw)
In-Reply-To: <jwv4pgtr01d.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun\, 14 Oct 2007 15\:05\:16 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> --- buffer.c 10 oct 2007 11:29:34 -0400 1.535
> +++ buffer.c 14 oct 2007 15:03:35 -0400
> @@ -568,6 +568,7 @@
>
> b = (struct buffer *) allocate_buffer ();
> b->size = sizeof (struct buffer) / sizeof (EMACS_INT);
> + XSETPVECTYPE (b, PVEC_BUFFER);
Wouldn't it be better to move the last two lines into allocate_buffer?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2007-10-14 20:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 7:13 23.0.50; Crash in ediff-regions-linewise Toby Allsopp
2007-10-13 19:47 ` Richard Stallman
2007-10-14 8:19 ` Toby Allsopp
2007-10-14 19:05 ` Stefan Monnier
2007-10-14 20:01 ` Andreas Schwab [this message]
2007-10-16 15:43 ` Stefan Monnier
2007-10-15 20:39 ` Toby Allsopp
2007-10-16 15:50 ` Stefan Monnier
2007-10-17 5:42 ` Toby Allsopp
2007-10-17 14:03 ` Stefan Monnier
[not found] ` <874pgu5bxh.fsf@candyboy.here>
2007-10-15 1:37 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je8x6531pt.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=emacs-pretest-bug@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rms@gnu.org \
--cc=toby@mi6.gen.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.