From: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org, Kenichi Handa <handa@m17n.org>
Subject: Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
Date: Thu, 12 Oct 2006 14:47:34 +0200 [thread overview]
Message-ID: <je64epr995.fsf@sykes.suse.de> (raw)
In-Reply-To: <20061012123556.GA89997@gothmog.pc> (Giorgos Keramidas's message of "Thu, 12 Oct 2006 15:35:56 +0300")
Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> It seems to include this part:
>
> + if [ ! -d ${INSTALLDIR} ] ; then \
> + ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> + else true; fi
>
> We don't really *need* to have an else branch in all statements. We can
> write this as:
>
> + if [ ! -d ${INSTALLDIR} ] ; then \
> + ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> + fi
Except that some old shells will cause the whole command to fail if the
condition fails.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-10-12 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 23:22 [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist Giorgos Keramidas
2006-10-12 0:31 ` Giorgos Keramidas
2006-10-12 5:59 ` Kenichi Handa
2006-10-12 12:35 ` Giorgos Keramidas
2006-10-12 12:47 ` Andreas Schwab [this message]
2006-10-12 13:12 ` Giorgos Keramidas
2006-10-12 12:52 ` David Kastrup
2006-10-12 13:10 ` Kenichi Handa
2006-10-12 13:13 ` Giorgos Keramidas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je64epr995.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.