From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: jdsmith@as.arizona.edu (JD Smith) Newsgroups: gmane.emacs.devel Subject: Re: Encoding needed for `browse-url' URLs (IDLWAVE html help) Date: Fri, 13 Jan 2006 23:50:58 -0700 Message-ID: References: NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1137221596 23082 80.91.229.2 (14 Jan 2006 06:53:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2006 06:53:16 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 14 07:53:12 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ExfHi-0007Ud-Ov for ged-emacs-devel@m.gmane.org; Sat, 14 Jan 2006 07:53:11 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ExfJr-00037P-Sl for ged-emacs-devel@m.gmane.org; Sat, 14 Jan 2006 01:55:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ExfI3-00035u-0G for emacs-devel@gnu.org; Sat, 14 Jan 2006 01:53:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ExfI0-00035G-Hu for emacs-devel@gnu.org; Sat, 14 Jan 2006 01:53:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ExfHx-000358-Mx for emacs-devel@gnu.org; Sat, 14 Jan 2006 01:53:26 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1ExfL4-00039g-D2 for emacs-devel@gnu.org; Sat, 14 Jan 2006 01:56:38 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1ExfFi-0007Et-Rf for emacs-devel@gnu.org; Sat, 14 Jan 2006 07:51:06 +0100 Original-Received: from c-69-252-140-73.hsd1.az.comcast.net ([69.252.140.73]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Jan 2006 07:51:06 +0100 Original-Received: from jdsmith by c-69-252-140-73.hsd1.az.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Jan 2006 07:51:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 27 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c-69-252-140-73.hsd1.az.comcast.net User-Agent: NewsWatcher-X 2.2.3b2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49066 Archived-At: In article , David Reitter wrote: > I got the below bug report and I found that idlwave does not encode > the URL in `idlwave-help-html-link', i.e. if the path contains a > space, it is not encoded as "%20". > > Are `browse-url' and the function pointed to in `browse-url-browser- > function' supposed to handle such URLs or not? > If not, it's a bug in idlwave-mode (but possibly in other places). > > (Never mind the reported crash - that was due to an undocumented > 'feature' in OS X with not-encoded URLs and the patch for browsing > URLs with the standard browser.) There is apparently a function `browse-url-file-url' which I overlooked, which does this for you. Perhaps adding this to the browse-url docstring would be wise. Even better would be calling it directly on file-based urls. It does all the encoding necessary. CVS Emacs didn't crash under OSX when sending file:// urls with unencoded spaces, so that must be an AquaMacs only thing. I'll submit this fix along with others in a version of IDLWAVE I'm preparing for inclusion in Emacs 22 (which does away with the need for vendor-supplied documentation and scans, among other things). JD