From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files Date: Tue, 13 Oct 2015 14:28:17 -0400 Message-ID: References: <20151013135354.28594.43074@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444761017 25404 80.91.229.3 (13 Oct 2015 18:30:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Oct 2015 18:30:17 +0000 (UTC) Cc: Oleh Krehel To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 13 20:30:17 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zm4Ks-0006i3-8X for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 20:30:06 +0200 Original-Received: from localhost ([::1]:38747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm4Kr-0006PE-JY for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 14:30:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm4JB-00044d-KB for emacs-devel@gnu.org; Tue, 13 Oct 2015 14:28:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm4JA-0001jV-Sh for emacs-devel@gnu.org; Tue, 13 Oct 2015 14:28:21 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm4JA-0001jM-QN; Tue, 13 Oct 2015 14:28:20 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Zm4J8-0002jf-Nb; Tue, 13 Oct 2015 14:28:18 -0400 X-Spook: mindwar Mysql injection Spammer Drug Administration X-Ran: K+Rv.*#G>Ze${9}u.S}zoXg\6c@6a2HXCzW~>#?[:k9w`%dje("$:%{9@Y)v>{:00pe&qC X-Hue: cyan X-Attribution: GM In-Reply-To: (Oleh Krehel's message of "Tue, 13 Oct 2015 13:53:55 +0000") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191504 Archived-At: Oleh Krehel wrote: > branch: master > commit 6d6bf466477b004035a4314886e35214c6f8603b > (defvar dired-compress-file-suffixes > - '(("\\.gz\\'" "" "gunzip") > + '(("\\.tar\\.gz" "" "tar" "-zxvf") Missing anchor. > + ("\\.gz\\'" "" "gunzip") > ("\\.tgz\\'" ".tar" "gunzip") > ("\\.Z\\'" "" "uncompress") This makes ".tar.gz" and ".tgz" be treated differently. Isn't that a little odd? Also: .tar.bz2, .tar.xz, .tar, etc are not handled, only the gzip version. > - (REGEXP NEW-SUFFIX PROGRAM) > + (REGEXP NEW-SUFFIX PROGRAM &rest ARGS) Using "&rest" will make it difficult to add any future elements beyond ARGS. Also it seems like this merits a NEWS entry.