From: Glenn Morris <rgm@gnu.org>
To: emacs-devel@gnu.org
Cc: Oleh Krehel <ohwoeowho@gmail.com>
Subject: Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files
Date: Tue, 13 Oct 2015 14:28:17 -0400 [thread overview]
Message-ID: <j6si5esjwe.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <E1Zm01b-0007SW-BB@vcs.savannah.gnu.org> (Oleh Krehel's message of "Tue, 13 Oct 2015 13:53:55 +0000")
Oleh Krehel wrote:
> branch: master
> commit 6d6bf466477b004035a4314886e35214c6f8603b
> (defvar dired-compress-file-suffixes
> - '(("\\.gz\\'" "" "gunzip")
> + '(("\\.tar\\.gz" "" "tar" "-zxvf")
Missing anchor.
> + ("\\.gz\\'" "" "gunzip")
> ("\\.tgz\\'" ".tar" "gunzip")
> ("\\.Z\\'" "" "uncompress")
This makes ".tar.gz" and ".tgz" be treated differently.
Isn't that a little odd?
Also: .tar.bz2, .tar.xz, .tar, etc are not handled, only the gzip version.
> - (REGEXP NEW-SUFFIX PROGRAM)
> + (REGEXP NEW-SUFFIX PROGRAM &rest ARGS)
Using "&rest" will make it difficult to add any future elements beyond ARGS.
Also it seems like this merits a NEWS entry.
next parent reply other threads:[~2015-10-13 18:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151013135354.28594.43074@vcs.savannah.gnu.org>
[not found] ` <E1Zm01b-0007SW-BB@vcs.savannah.gnu.org>
2015-10-13 18:28 ` Glenn Morris [this message]
2015-10-13 18:38 ` master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files Paul Eggert
2015-10-14 7:58 ` Oleh Krehel
2015-10-14 15:17 ` Paul Eggert
2015-10-14 7:56 ` Oleh Krehel
2015-10-14 16:16 ` Eli Zaretskii
2015-10-14 18:51 ` Achim Gratz
2015-10-14 19:02 ` Eli Zaretskii
2015-10-15 13:07 ` Oleh Krehel
2015-10-15 15:55 ` Eli Zaretskii
2015-10-15 19:46 ` Achim Gratz
2015-10-15 16:48 ` Glenn Morris
2015-10-15 17:06 ` Eli Zaretskii
2015-10-16 10:44 ` Oleh Krehel
2015-10-16 13:23 ` Eli Zaretskii
2015-10-16 13:47 ` Oleh Krehel
2015-10-16 14:35 ` Eli Zaretskii
2015-10-20 8:59 ` Oleh Krehel
2015-10-20 14:57 ` Eli Zaretskii
2015-10-21 7:57 ` Oleh Krehel
2015-10-21 15:04 ` Oleh Krehel
2015-10-21 16:28 ` Eli Zaretskii
2015-10-22 10:59 ` Oleh Krehel
2015-10-20 22:51 ` Juri Linkov
2015-10-21 8:00 ` Oleh Krehel
2015-10-16 15:35 ` Paul Eggert
2015-10-16 16:11 ` Eli Zaretskii
2015-10-16 16:26 ` Glenn Morris
2015-10-16 12:11 ` Oleh Krehel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j6si5esjwe.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.