Sorting by todo-keyword

Sorting by todo-keyword

[Jan Seeger]

I want to sort my todo agenda view by todo keyword. Is that currently
possible? It seems from the org-agenda-sorting-strategy keyword, that
this is not the case.

Regards,
Jan Seeger

Re: Sorting by todo-keyword

[Christian Egli]

Hi

"Jan Seeger" <jan.seeger@thenybble.de> writes:
> I want to sort my todo agenda view by todo keyword. Is that currently
> possible? 

AFAIK No, currently you cannot do that.

> It seems from the org-agenda-sorting-strategy keyword, that
> this is not the case.

I posted a patch for this against org 5.18a way back
(http://article.gmane.org/gmane.emacs.orgmode/5066). You'd have to
forward port it to the current version of org, but git should help you
there. 

Let me know if you get anywhere.

HTH
Christian

Re: Re: Sorting by todo-keyword

[Manish]

On Tue, Aug 12, 2008 at 1:36 PM, Christian Egli wrote:
> Hi
>
> "Jan Seeger" writes:
>> I want to sort my todo agenda view by todo keyword. Is that currently
>> possible?
>
> AFAIK No, currently you cannot do that.
>
>> It seems from the org-agenda-sorting-strategy keyword, that
>> this is not the case.
>
> I posted a patch for this against org 5.18a way back
> (http://article.gmane.org/gmane.emacs.orgmode/5066). You'd have to
> forward port it to the current version of org, but git should help you
> there.
>
> Let me know if you get anywhere.

I tried applying the patch but it failed.

zms@master:~/elisp/org-mode.git$ git-apply 5066-001.bin
5066-001.bin:178: trailing whitespace.
		'priority (org-get-priority txt)
5066-001.bin:192: trailing whitespace.
	 (donepa (member ta org-done-keywords))
error: org.el: No such file or directory
zms@master:~/elisp/org-mode.git$ emacs22 -nw     #cleaning the
trailing whitespace
zms@master:~/elisp/org-mode.git$ git-apply 5066-001.bin
error: org.el: No such file or directory
zms@master:~/elisp/org-mode.git$ cd lisp/
zms@master:~/elisp/org-mode.git/lisp$ git-apply ../5066-001.bin
error: patch failed: lisp/org.el:2679
error: lisp/org.el: patch does not apply

Best,
-- Manish

Re: Sorting by todo-keyword

[Christian Egli]

Manish <mailtomanish.sharma@gmail.com> writes:

> On Tue, Aug 12, 2008 at 1:36 PM, Christian Egli wrote:
>> Hi
>>
>> "Jan Seeger" writes:
>>> I want to sort my todo agenda view by todo keyword. Is that currently
>>> possible?
>>
>> AFAIK No, currently you cannot do that.
>>
>>> It seems from the org-agenda-sorting-strategy keyword, that
>>> this is not the case.
>>
>> I posted a patch for this against org 5.18a way back
>> (http://article.gmane.org/gmane.emacs.orgmode/5066). You'd have to
>> forward port it to the current version of org, but git should help you
>> there.
>>
>> Let me know if you get anywhere.
>
> I tried applying the patch but it failed.

Did you apply against 5.18a? You should be able to checkout 5.18a,
apply the patch and try to do a rebase to bring the patch up to the
current version of org.

If that doesn't work then I guess some manual work is required.

HTH
Christian

Re: Re: Sorting by todo-keyword

[Manish]

Sorry, I did not.

Will try this later tonight.  Thanks,

-- Manish

On Tue, Aug 12, 2008 at 2:22 PM, Christian Egli <christian.egli@sbszh.ch> wrote:
> Manish <mailtomanish.sharma@gmail.com> writes:
>
>> On Tue, Aug 12, 2008 at 1:36 PM, Christian Egli wrote:
>>> Hi
>>>
>>> "Jan Seeger" writes:
>>>> I want to sort my todo agenda view by todo keyword. Is that currently
>>>> possible?
>>>
>>> AFAIK No, currently you cannot do that.
>>>
>>>> It seems from the org-agenda-sorting-strategy keyword, that
>>>> this is not the case.
>>>
>>> I posted a patch for this against org 5.18a way back
>>> (http://article.gmane.org/gmane.emacs.orgmode/5066). You'd have to
>>> forward port it to the current version of org, but git should help you
>>> there.
>>>
>>> Let me know if you get anywhere.
>>
>> I tried applying the patch but it failed.
>
> Did you apply against 5.18a? You should be able to checkout 5.18a,
> apply the patch and try to do a rebase to bring the patch up to the
> current version of org.
>
> If that doesn't work then I guess some manual work is required.
>
> HTH
> Christian
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

Re: Re: Sorting by todo-keyword

[Manish]

  > On Tue, Aug 12, 2008 at 2:22 PM, Christian Egli wrote:
  >> Manish writes:
  >>
  >>> On Tue, Aug 12, 2008 at 1:36 PM, Christian Egli wrote:
  >>>> Hi
  >>>>
  >>>> "Jan Seeger" writes:
  >>>>> I want to sort my todo agenda view by todo keyword. Is that currently
  >>>>> possible?
  >>>>
  >>>> AFAIK No, currently you cannot do that.
  >>>>
  >>>>> It seems from the org-agenda-sorting-strategy keyword, that
  >>>>> this is not the case.
  >>>>
  >>>> I posted a patch for this against org 5.18a way back
  >>>> (http://article.gmane.org/gmane.emacs.orgmode/5066). You'd have to
  >>>> forward port it to the current version of org, but git should help you
  >>>> there.
  >>>>
  >>>> Let me know if you get anywhere.
  >>>
  >>> I tried applying the patch but it failed.
  >>
  >> Did you apply against 5.18a? You should be able to checkout 5.18a,
  >> apply the patch and try to do a rebase to bring the patch up to the
  >> current version of org.
  >>
  >> If that doesn't work then I guess some manual work is required.

I tried applying the patch to 5.18a but it failed again.  How can I
help get more debug information?

,----
| lappy:~/elisp/org-mode.git $ git checkout -b release_5.18a release_5.18a
| Checking out files: 100% (112/112), done.
| Switched to a new branch "release_5.18a"
| lappy:~/elisp/org-mode.git $ git branch
|   master
| * release_5.18a
|   zms
| lappy:~/elisp/org-mode.git $ git-apply.exe 5066-001.bin
| error: patch failed: org.el:2679
| error: org.el: patch does not apply
`----

Regards,
-- Manish

Re: Sorting by todo-keyword

[Christian Egli]

Manish <mailtomanish.sharma@gmail.com> writes:

> I tried applying the patch to 5.18a but it failed again.  How can I
> help get more debug information?
>
> ,----
> | lappy:~/elisp/org-mode.git $ git checkout -b release_5.18a release_5.18a
> | Checking out files: 100% (112/112), done.
> | Switched to a new branch "release_5.18a"
> | lappy:~/elisp/org-mode.git $ git branch
> |   master
> | * release_5.18a
> |   zms
> | lappy:~/elisp/org-mode.git $ git-apply.exe 5066-001.bin
> | error: patch failed: org.el:2679
> | error: org.el: patch does not apply
> `----

Yes, I know, I tried myself. The problem is most likely that Carsten
rearranged the source code substantially. My patch was for org.el but
the changes should now probably be applied to lisp/org-agenda.el.

I don't know git well enough to judge if there is an automated way to
bring this patch back to life. The only way I see ATM is to manually
port it to the current version of org.

Basically the patch is (was) fairly simple:

* add a function org-cmp-todo-state along the lines of org-cmp-* which
  compares todo states.

* add this function to org-entries-lessp

* adapt the various functions that are invoked by
  org-finalize-agenda-entries (org-agenda-get-todos,
  org-agenda-get-scheduled, etc) to include the todo state in the
  properties of the text for the agenda line. You can probably get
  some inspiration from my old patch. 

HTH
Christian