From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template): Date: Fri, 22 Nov 2013 21:37:12 -0500 Message-ID: References: <6vfvqpl5gh.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1385174232 1653 80.91.229.3 (23 Nov 2013 02:37:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Nov 2013 02:37:12 +0000 (UTC) Cc: emacs-devel To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 23 03:37:19 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vk35x-0007pm-JZ for ged-emacs-devel@m.gmane.org; Sat, 23 Nov 2013 03:37:17 +0100 Original-Received: from localhost ([::1]:41972 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vk35x-0004uP-5i for ged-emacs-devel@m.gmane.org; Fri, 22 Nov 2013 21:37:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vk35u-0004uK-IF for emacs-devel@gnu.org; Fri, 22 Nov 2013 21:37:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vk35t-0001F4-Gu for emacs-devel@gnu.org; Fri, 22 Nov 2013 21:37:14 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vk35t-0001F0-DA for emacs-devel@gnu.org; Fri, 22 Nov 2013 21:37:13 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vk35s-0003Oq-QV; Fri, 22 Nov 2013 21:37:12 -0500 X-Spook: BLU-114/B e-cash SHA broadside AVN data haven morse Exon X-Ran: HUS"m3a4O}B3603+2SOwi;,W3i2Q?|d.g\6V`J@GY(/4:!9tm9'#`RPS,s4i9LvRriZ`:= X-Hue: white X-Attribution: GM In-Reply-To: (Bozhidar Batsov's message of "Fri, 22 Nov 2013 14:38:17 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165593 Archived-At: Thanks for adding a test/ChangeLog entry. Do please list the names of the tests in the entry. ChangeLog entries should name every function, variable that they touch. I notice this did not happen eg in http://lists.gnu.org/archive/html/emacs-diffs/2013-11/msg00216.html which changed an option, added several new functions, and modified another, but only mentioned the last in the ChangeLog. Similarly http://lists.gnu.org/archive/html/emacs-diffs/2013-11/msg00150.html does not list the two new options as entities in their own right. Please could you review all your past changes with an eye to that, and improve the ChangeLogs where necessary? Also, maybe you want to add a NEWS entry about those new options. This need be nothing more than: ** New Ruby mode options: foo, bar. in the "Changes in Specialized Modes and Packages in Emacs 24.4" section.