all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Use nntp-open-tls-stream in url-snews
@ 2007-11-20 21:16 Diane Murray
  2007-11-28  8:35 ` Glenn Morris
  0 siblings, 1 reply; 4+ messages in thread
From: Diane Murray @ 2007-11-20 21:16 UTC (permalink / raw)
  To: emacs-devel

url-snews still uses `nntp-open-ssl-stream' as the default function to
open connections unless the `url-gateway-method' is set to tls.  This
patch changes it to use `nntp-open-tls-stream'.  This also fixes a bug
where an error would occur because the function names weren't quoted.


2007-11-20  Diane Murray  <disumu@x3y2z1.net>

	* url-news.el (url-snews): Always use `nntp-open-tls-stream'.


*** url-news.el	22 Sep 2007 04:02:28 +0200	1.14.2.2
--- url-news.el	20 Nov 2007 22:05:17 +0100	
***************
*** 127,135 ****
  
  ;;;###autoload
  (defun url-snews (url)
!   (let ((nntp-open-connection-function (if (eq 'tls url-gateway-method)
! 					   nntp-open-tls-stream
! 					 nntp-open-ssl-stream)))
      (url-news url)))
  
  (provide 'url-news)
--- 127,133 ----
  
  ;;;###autoload
  (defun url-snews (url)
!   (let ((nntp-open-connection-function 'nntp-open-tls-stream))
      (url-news url)))
  
  (provide 'url-news)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Use nntp-open-tls-stream in url-snews
  2007-11-20 21:16 Use nntp-open-tls-stream in url-snews Diane Murray
@ 2007-11-28  8:35 ` Glenn Morris
  2007-12-02  2:26   ` Diane Murray
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2007-11-28  8:35 UTC (permalink / raw)
  To: Diane Murray; +Cc: emacs-devel

Diane Murray wrote:

> url-snews still uses `nntp-open-ssl-stream' as the default function to
> open connections unless the `url-gateway-method' is set to tls.  This
> patch changes it to use `nntp-open-tls-stream'.

url-vars says ssl is deprecated, but it is still listed. So shouldn't
the change be to invert the test, ie:

> !   (let ((nntp-open-connection-function (if (eq 'ssl url-gateway-method)
> ! 					   nntp-open-ssl-stream
> ! 					 nntp-open-tls-stream)))

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Use nntp-open-tls-stream in url-snews
  2007-11-28  8:35 ` Glenn Morris
@ 2007-12-02  2:26   ` Diane Murray
  2007-12-02  4:10     ` Glenn Morris
  0 siblings, 1 reply; 4+ messages in thread
From: Diane Murray @ 2007-12-02  2:26 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

Glenn Morris wrote:

> url-vars says ssl is deprecated, but it is still listed. So shouldn't
> the change be to invert the test, ie:

> > !   (let ((nntp-open-connection-function (if (eq 'ssl url-gateway-method)
> > ! 					   nntp-open-ssl-stream
> > ! 					 nntp-open-tls-stream)))

Yes, I guess so.  Sorry I didn't think of that.

Diane Murray

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Use nntp-open-tls-stream in url-snews
  2007-12-02  2:26   ` Diane Murray
@ 2007-12-02  4:10     ` Glenn Morris
  0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2007-12-02  4:10 UTC (permalink / raw)
  To: Diane Murray; +Cc: emacs-devel

Diane Murray wrote:

> Glenn Morris wrote:
>
>> url-vars says ssl is deprecated, but it is still listed. So shouldn't
>> the change be to invert the test, ie:
>
>> > !   (let ((nntp-open-connection-function (if (eq 'ssl url-gateway-method)
>> > ! 					   nntp-open-ssl-stream
>> > ! 					 nntp-open-tls-stream)))
>
> Yes, I guess so.  Sorry I didn't think of that.

No worries. Thanks for pointing out that something was amiss here.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-12-02  4:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-20 21:16 Use nntp-open-tls-stream in url-snews Diane Murray
2007-11-28  8:35 ` Glenn Morris
2007-12-02  2:26   ` Diane Murray
2007-12-02  4:10     ` Glenn Morris

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.