From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.devel Subject: Re: "patch" to smtpmail.el Date: Thu, 09 May 2002 19:40:12 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200205091459.g49ExCS05789@aztec.santafe.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1020966125 1667 127.0.0.1 (9 May 2002 17:42:05 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 9 May 2002 17:42:05 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 175rvZ-0000Qm-00 for ; Thu, 09 May 2002 19:42:05 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 175s4H-0000ef-00 for ; Thu, 09 May 2002 19:51:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 175rvb-0006We-00; Thu, 09 May 2002 13:42:07 -0400 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net ([217.13.230.178] helo=yxa.extundo.com) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 175rtu-0006LQ-00; Thu, 09 May 2002 13:40:22 -0400 Original-Received: from localhost.localdomain (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.3/8.12.3) with ESMTP id g49HeJ5p004778; Thu, 9 May 2002 19:40:20 +0200 Original-To: rms@gnu.org In-Reply-To: <200205091459.g49ExCS05789@aztec.santafe.edu> (Richard Stallman's message of "Thu, 9 May 2002 08:59:12 -0600 (MDT)") Original-Lines: 43 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2.50 (i686-pc-linux-gnu) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:3775 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3775 I committed something similar recently (rev 1.43). Or were you thinking about the variable name? I chosed mail-address instead. I don't understand why the previous idea didn't work though. Shouldn't letting a variable to a variable take priority over the buffer-local or global variable (as the case may be)? Or is it nonsensical to let a variable to itself just to work around its buffer localness? O well. Richard Stallman writes: > I think this is a safer, cleaner way to write that change. > Does it work? > > *** smtpmail.el.~1.42.~ Wed May 8 09:17:18 2002 > --- smtpmail.el Wed May 8 22:50:36 2002 > *************** > *** 220,225 **** > --- 220,226 ---- > (case-fold-search nil) > delimline > (mailbuf (current-buffer)) > + (address user-mail-address) > (smtpmail-code-conv-from > (if enable-multibyte-characters > (let ((sendmail-coding-system smtpmail-code-conv-from)) > *************** > *** 260,266 **** > ;; they put one in themselves. > (goto-char (point-min)) > (if (not (re-search-forward "^From:" delimline t)) > ! (let* ((login user-mail-address) > (fullname (user-full-name))) > (cond ((eq mail-from-style 'angles) > (insert "From: " fullname) > --- 261,267 ---- > ;; they put one in themselves. > (goto-char (point-min)) > (if (not (re-search-forward "^From:" delimline t)) > ! (let* ((login address) > (fullname (user-full-name))) > (cond ((eq mail-from-style 'angles) > (insert "From: " fullname)