From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.devel Subject: Re: smtpmail.el and 1msg Date: Thu, 11 Mar 2004 19:52:34 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <16455.40870.198614.821339@freezer.sbum.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1079158253 30671 80.91.224.253 (13 Mar 2004 06:10:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 13 Mar 2004 06:10:53 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Mar 13 07:10:42 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B22M6-0002Dp-00 for ; Sat, 13 Mar 2004 07:10:42 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B22M6-0002jS-00 for ; Sat, 13 Mar 2004 07:10:42 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B1yuH-0001hz-93 for emacs-devel@quimby.gnus.org; Fri, 12 Mar 2004 21:29:45 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B1xVB-0002lh-0q for emacs-devel@gnu.org; Fri, 12 Mar 2004 19:59:45 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B1VIS-0002So-4r for emacs-devel@gnu.org; Thu, 11 Mar 2004 13:53:15 -0500 Original-Received: from [217.13.230.178] (helo=yxa.extundo.com) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.30) id 1B1VIR-0002SP-BH for emacs-devel@gnu.org; Thu, 11 Mar 2004 13:52:43 -0500 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.11/8.12.11) with ESMTP id i2BIqb8s015098 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Thu, 11 Mar 2004 19:52:37 +0100 Original-To: Stefan Monnier X-Hashcash: 0:040311:monnier@iro.umontreal.ca:8feac48ba5c3616e X-Hashcash: 0:040311:emacs-devel@gnu.org:5fe5bf209df04522 In-Reply-To: (Stefan Monnier's message of "11 Mar 2004 09:37:03 -0500") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20377 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20377 Stefan Monnier writes: >> Thanks! I believe this also explains a few bug reports I've got, with >> the exact same symptoms as the ones you describe. > > While I think it's good to add support for 1msg, I also think it would be > worthwhile to fix the spinning problem. After all, if the other end closes > the connection, we should detect it. Do we? If `no' why not and if `yes' > why does it spin? Detecting closed connections, during the spin loop, was the intention of my patch. They weren't detected before. What do you think? OLD: (while (not (search-forward "\r\n" nil t)) (accept-process-output process) (goto-char smtpmail-read-point)) NEW: (while (not (search-forward "\r\n" nil t)) (unless (memq (process-status process) '(open run)) (throw 'done nil)) (accept-process-output process) (goto-char smtpmail-read-point))