From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.devel Subject: Re: nndb.el requires tcp Date: Fri, 10 Sep 2004 13:49:33 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <01c49720$Blat.v2.2.2$b48fff20@zahav.net.il> <01c49729$Blat.v2.2.2$ea11b9a0@zahav.net.il> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1094817037 776 80.91.224.253 (10 Sep 2004 11:50:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 10 Sep 2004 11:50:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 10 13:50:29 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C5jvB-0003zM-00 for ; Fri, 10 Sep 2004 13:50:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C5k0Y-00051Z-HN for ged-emacs-devel@m.gmane.org; Fri, 10 Sep 2004 07:56:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C5k0R-00051I-JZ for emacs-devel@gnu.org; Fri, 10 Sep 2004 07:55:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C5k0Q-00050V-Lh for emacs-devel@gnu.org; Fri, 10 Sep 2004 07:55:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C5k0Q-00050L-Iy for emacs-devel@gnu.org; Fri, 10 Sep 2004 07:55:54 -0400 Original-Received: from [217.13.230.178] (helo=yxa.extundo.com) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1C5jui-0004aG-D3; Fri, 10 Sep 2004 07:50:01 -0400 Original-Received: from latte.josefsson.org (c494102a.s-bi.bostream.se [217.215.27.65]) (authenticated bits=0) by yxa.extundo.com (8.12.11/8.12.11/Debian-5) with ESMTP id i8ABnn9J023348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=OK); Fri, 10 Sep 2004 13:49:52 +0200 Original-To: Eli Zaretskii X-Hashcash: 0:040910:eliz@gnu.org:f05b2384a545c589 X-Hashcash: 0:040910:emacs-devel@gnu.org:a57f295ba0665fde In-Reply-To: <01c49729$Blat.v2.2.2$ea11b9a0@zahav.net.il> (Eli Zaretskii's message of "Fri, 10 Sep 2004 14:31:51 +0300") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) X-Virus-Scanned: clamd / ClamAV version 0.75-1, clamav-milter version 0.75c on yxa-iv X-Virus-Status: Clean X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26961 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26961 "Eli Zaretskii" writes: >> From: Simon Josefsson >> Date: Fri, 10 Sep 2004 12:50:18 +0200 >> >> "Eli Zaretskii" writes: >> >> > lisp/gnus/nndb.el has this fragment near line 60: >> > >> > (eval-and-compile >> > (unless (fboundp 'open-network-stream) >> > (require 'tcp))) >> > >> > What is the reason for the conditional requrement, and what is the tcp >> > package it wants? >> > >> > The reason I ask is that open-network-stream is not fboundp in the >> > MS-DOS port, so nndb.el cannot be byte-compiled, since the tcp package >> > is not there as well. > > Should I remove the entire eval-and-compile expression in the Emacs > CVS? I think that would be the right thing. I've done the same on the Gnus V5-10 branch as well, now. You could remove the duplicate (require 'cl) below the expression too.