From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.devel Subject: Re: "patch" to smtpmail.el Date: Tue, 07 May 2002 19:09:51 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: References: NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1020805794 27119 127.0.0.1 (7 May 2002 21:09:54 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 7 May 2002 21:09:54 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 175CDa-00073I-00 for ; Tue, 07 May 2002 23:09:54 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 175CLO-0007x6-00 for ; Tue, 07 May 2002 23:17:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 175AM3-0001lT-00; Tue, 07 May 2002 15:10:31 -0400 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net ([217.13.230.178] helo=yxa.extundo.com) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 1758Ta-0007VP-00 for ; Tue, 07 May 2002 13:10:10 -0400 Original-Received: from localhost.localdomain (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.3/8.12.3) with ESMTP id g47HA8Q4018385 for ; Tue, 7 May 2002 19:10:09 +0200 Original-To: emacs-devel@gnu.org In-Reply-To: (Simon Josefsson's message of "Tue, 07 May 2002 18:13:27 +0200") Original-Lines: 64 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2 (i686-pc-linux-gnu) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:3688 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3688 Could someone please commit this? It was acknowledged to work. It also fixes :version of an older patch. Is it possible to get CVS write permission, btw? How do I get that? 2002-05-07 Simon Josefsson * mail/smtpmail.el (smtpmail-send-it): Use user-mail-address from calling buffer. (smtpmail-auth-credentials): Bump :version to 21.4 (21.3 will not have the patch). Index: smtpmail.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/mail/smtpmail.el,v retrieving revision 1.41 diff -u -p -u -w -r1.41 smtpmail.el --- smtpmail.el 26 Apr 2002 18:59:08 -0000 1.41 +++ smtpmail.el 7 May 2002 17:09:05 -0000 @@ -165,7 +165,7 @@ looks like `user@realm'." (string :tag "Username") (choice (const :tag "Query when needed" nil) (string :tag "Password"))))) - :version "21.3" + :version "21.4" :group 'smtpmail) (defcustom smtpmail-starttls-credentials '(("" 25 "" "")) @@ -218,6 +218,7 @@ This is relative to `smtpmail-queue-dir' (case-fold-search nil) delimline (mailbuf (current-buffer)) + (user-mail-address user-mail-address) (smtpmail-code-conv-from (if enable-multibyte-characters (let ((sendmail-coding-system smtpmail-code-conv-from)) Simon Josefsson writes: > Gareth Owen writes: > >> This makes the process-buffer inherit user-mail-address from the message >> buffer. Useful to stop your "real" email address leaking out in headers >> like X-From and X-Return-Path headers added by the SMTP agent. >> >> BCC'd to maintainer. > > Does this patch work instead? > > Index: smtpmail.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/mail/smtpmail.el,v > retrieving revision 1.41 > diff -u -p -u -w -r1.41 smtpmail.el > --- smtpmail.el 26 Apr 2002 18:59:08 -0000 1.41 > +++ smtpmail.el 7 May 2002 16:13:26 -0000 > @@ -218,6 +218,7 @@ This is relative to `smtpmail-queue-dir' > (case-fold-search nil) > delimline > (mailbuf (current-buffer)) > + (user-mail-address user-mail-address) > (smtpmail-code-conv-from > (if enable-multibyte-characters > (let ((sendmail-coding-system smtpmail-code-conv-from))