From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Simon Josefsson <jas@extundo.com>
Newsgroups: gmane.emacs.bugs
Subject: Re: browse-url-galeon incorrect
Date: Wed, 15 May 2002 20:04:20 +0200
Sender: bug-gnu-emacs-admin@gnu.org
Message-ID: <ilu661pwamz.fsf@latte.josefsson.org>
References: <E177d4j-00063X-00@lemming.engeast.baynetworks.com>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1021486063 12542 127.0.0.1 (15 May 2002 18:07:43 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 15 May 2002 18:07:43 +0000 (UTC)
Cc: bug-gnu-emacs@gnu.org
Return-path: <bug-gnu-emacs-admin@gnu.org>
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 1783Be-0003G2-00
	for <gnu-bug-gnu-emacs@m.gmane.org>; Wed, 15 May 2002 20:07:43 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 1783Bx-0005gW-00; Wed, 15 May 2002 14:08:01 -0400
Original-Received: from 178.230.13.217.in-addr.dgcsystems.net ([217.13.230.178] helo=yxa.extundo.com)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 17838V-0005MM-00
	for <bug-gnu-emacs@gnu.org>; Wed, 15 May 2002 14:04:27 -0400
Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178])
	(authenticated bits=0)
	by yxa.extundo.com (8.12.3/8.12.3) with ESMTP id g4FI4KWa007121;
	Wed, 15 May 2002 20:04:20 +0200
Original-To: "Paul Smith" <pausmith@nortelnetworks.com>
In-Reply-To: <E177d4j-00063X-00@lemming.engeast.baynetworks.com> ("Paul
 Smith"'s message of "Tue, 14 May 2002 10:14:49 -0400")
Original-Lines: 35
User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2.50
 (i686-pc-linux-gnu)
Errors-To: bug-gnu-emacs-admin@gnu.org
X-BeenThere: bug-gnu-emacs@gnu.org
X-Mailman-Version: 2.0.9
Precedence: bulk
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
List-Id: Bug reports for GNU Emacs,
	the Swiss army knife of text editors <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/bug-gnu-emacs/>
Xref: main.gmane.org gmane.emacs.bugs:1383
X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:1383

"Paul Smith"<pausmith@nortelnetworks.com> writes:

> The browse-url.el:browse-url-galeon function is wrong.  It constructs
> the arguments to Galeon like this:
>
>       (concat "galeon " url) nil
>       browse-url-galeon-program
>       (append
>       browse-url-galeon-arguments
>       (if new-window '("-w" "--noraise"))
>       (list "-x" url))
>
> This is broken, though.  The "-x" argument overrides the setting of the
> new-window flag; "-x" means "Attempt to load URL in existing Galeon
> window", and the last such argument on the command line always takes
> precedence.  I think the "-x" should be removed, as I think it's not
> appropriate to have no way of passing _exactly_ the arguments you want,
> and only those.

The current code has been changed into the following.  Does it work
better for you?

...
         (process (apply 'start-process
			 (concat "galeon " url) nil
			 browse-url-galeon-program
			 (append
			  browse-url-galeon-arguments
                          (if (browse-url-maybe-new-window new-window)
			      (if browse-url-galeon-new-window-is-tab
				  '("--new-tab")
				'("--new-window" "--noraise"))
                            '("--existing"))
                          (list url)))))
...