From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.bugs Subject: Re: [PATCH] browse-url.el mozilla tab support Date: Thu, 10 Oct 2002 23:59:44 +0200 Sender: bug-gnu-emacs-admin@gnu.org Message-ID: References: <20021010173156.A0A17297D6@mixing.qc.dfo.ca> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1034287195 30991 127.0.0.1 (10 Oct 2002 21:59:55 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 10 Oct 2002 21:59:55 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17zlLW-00083a-00 for ; Thu, 10 Oct 2002 23:59:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17zlLn-00062L-00; Thu, 10 Oct 2002 18:00:11 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17zlLW-0005u1-00 for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2002 17:59:54 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17zlLQ-0005gs-00 for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2002 17:59:53 -0400 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net ([217.13.230.178] helo=yxa.extundo.com) by monty-python.gnu.org with esmtp (Exim 4.10) id 17zlLQ-0005fJ-00 for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2002 17:59:48 -0400 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.6/8.12.6) with ESMTP id g9ALxjFu027588 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Thu, 10 Oct 2002 23:59:45 +0200 Original-To: Steve Youngs X-Hashcash: 0:021010:youngs@xemacs.org:d7b8dce0840b1305 X-Hashcash: 0:021010:bug-gnu-emacs@gnu.org:7e20637b20fd7109 In-Reply-To: (Steve Youngs's message of "Fri, 11 Oct 2002 07:50:56 +1000") User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i386-debian-linux-gnu) Errors-To: bug-gnu-emacs-admin@gnu.org X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.bugs:3683 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:3683 Steve Youngs writes: > |--==> "SJ" == Simon Josefsson writes: > > SJ> Steve, have you signed papers for browse-url.el? I wanted to get > SJ> Emacs to include your XEmacs browse-url.el patch too. Thanks. > SJ> (Maybe papers aren't required for that patch though..) > > Not for browse-url.el specifically, no. Let me know if you need it. What does the Emacs maintainers think? Are papers necessary for the following patch, which mimics already existing Galeon code? --- browse-url.el.~1.23.~ 2002-07-25 20:49:46.000000000 +0200 +++ browse-url.el 2002-10-10 16:34:46.000000000 +0200 @@ -335,6 +335,13 @@ :type '(repeat (string :tag "Argument")) :group 'browse-url) +(defcustom browse-url-mozilla-new-window-is-tab nil + "*Whether to open up new windows in a tab or a new window. +If non-nil, then open the URL in a new tab rather than a new window if +`browse-url-mozilla' is asked to open it in a new window." + :type 'boolean + :group 'browse-url) + (defcustom browse-url-galeon-new-window-is-tab nil "*Whether to open up new windows in a tab or a new window. If non-nil, then open the URL in a new tab rather than a new window if @@ -862,7 +873,8 @@ (setq url (replace-match (format "%%%x" (string-to-char (match-string 0 url))) t t url))) (let* ((process-environment (browse-url-process-environment)) - (process (apply 'start-process + (process + (apply 'start-process (concat "mozilla " url) nil browse-url-mozilla-program (append @@ -870,7 +882,11 @@ (list "-remote" (concat "openURL(" url - (if new-window ",new-window") + (if (browse-url-maybe-new-window + new-window) + (if browse-url-mozilla-new-window-is-tab + ",new-tab") + ",new-window") ")")))))) (set-process-sentinel process `(lambda (process change)